fix: do not log BadLocationException when colorizing from tokenizer thread - #888
Merged
sebthom merged 1 commit intoMay 30, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…hread tokenizer thread runs asynchronously to modifications to the document, so it is expected that the colorizer may throw BadLocationExceptions, and there is no need to log these
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
joaodinissf
added a commit
to joaodinissf/lsp4e
that referenced
this pull request
Jun 4, 2025
…tegy A document may be modified concurrently by multiple threads. This can cause `BadLocationException`s, which should not be logged unless the log trace is enabled for the LanguageServerPlugin. Follows a similar pattern to: eclipse-tm4e/tm4e#888
joaodinissf
added a commit
to joaodinissf/lsp4e
that referenced
this pull request
Jun 4, 2025
…tegy A document may be modified concurrently by multiple threads. This can cause `BadLocationException`s, which should not be logged unless the log trace is enabled for the LanguageServerPlugin. Follows a similar pattern to: eclipse-tm4e/tm4e#888
joaodinissf
added a commit
to joaodinissf/lsp4e
that referenced
this pull request
Jun 4, 2025
…tegy A document may be modified concurrently by multiple threads. This can cause `BadLocationException`s, which should not be logged unless the log trace is enabled for the LanguageServerPlugin. Follows a similar pattern to: eclipse-tm4e/tm4e#888
rubenporras
pushed a commit
to eclipse-lsp4e/lsp4e
that referenced
this pull request
Jun 4, 2025
…tegy A document may be modified concurrently by multiple threads. This can cause `BadLocationException`s, which should not be logged unless the log trace is enabled for the LanguageServerPlugin. Follows a similar pattern to: eclipse-tm4e/tm4e#888
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokenizer thread runs asynchronously to modifications to the document, so it is expected that the colorizer may throw BadLocationExceptions, and there is no need to log these