feat(langcfg): respect embedded content types for commenting/auto edit - #960
Merged
sebthom merged 3 commits intoNov 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sebthom
force-pushed
the
partition-aware-langcfg
branch
4 times, most recently
from
ca9becd to
06eb4cd
Compare
November 17, 2025 11:31
Whitespace-only base regions (typically blank lines) between identical embedded types were creating extra partitions. Merge these gaps in computePartitioning so fenced/embedded blocks remain single contiguous regions.
Auto-edit and comment paths now resolve the caret's effective content types through TM partitions before running auto-close, surround, or toggle logic so embedded scopes (e.g., fenced CSS/JS) get their own tokens. Commands fall back to the outer document type only when the partition yields no mapping.
sebthom
force-pushed
the
partition-aware-langcfg
branch
from
06eb4cd to
7ae8349
Compare
November 17, 2025 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-edit and comment paths (e.g. line comment toggling) now resolve the caret's effective content types through TM partitions before running auto-close, surround, or toggle logic so embedded scopes (e.g., fenced CSS/JS) get their own tokens. Commands fall back to the outer document type only when the partition yields no mapping.