fix(ui): make tmTheme JSON/YAML/PLIST selectors match TextMate scopes - #984
Merged
sebthom merged 2 commits intoDec 30, 2025
Merged
fix(ui): make tmTheme JSON/YAML/PLIST selectors match TextMate scopes#984sebthom merged 2 commits into
sebthom merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
`type` string instead of the token's TextMate scopes stack, so selectors like `entity.other` would not match `entity.other.inherited-class.java` and required TM4E-specific token types as a workaround. Now tmTheme-style themes (json/yaml/plist/xml) match against the real scopes stack; CSS themes remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Themes in TextMate formats were matched against TM4E's encoded token type string instead of the token's TextMate scopes stack, so selectors like entity.other would not match entity.other.inherited-class.java and required TM4E-specific token types as a workaround.
Now tmTheme-style themes (json/yaml/plist/xml) match against the real scopes stack; CSS themes remain unchanged.
Addresses #983