Only import runner from edge_impulse_linux - #36
Open
AIWintermuteAI wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ideally we also want to re-write the install to be modular, e.g. pip install edge_impulse_linux[all] pip install edge_impulse_linux[image] pip install edge_impulse_linux[audio] pip install edge_impulse_linux[minimal] |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a side effect of how package init files is done now, a missing PortAudio/OpenCV crashes the whole package import, even for user who did not need audio/image.
With this change users who only need ImpulseRunner can now import edge_impulse_linux without having pyaudio or opencv-python installed. This removes awkward comments like this
NB: edge_impulse_linux.audio and edge_impulse_linux.image are no longer auto-loaded as attributes of the package. Code that relied on import edge_impulse_linux; edge_impulse_linux.audio.AudioImpulseRunner would break. However, all the examples use explicit submodule imports (from edge_impulse_linux.audio import ..., from edge_impulse_linux.image import ...), which still works, as Python imports the submodule on demand. So the examples are unaffected.