This repository was archived by the owner on Feb 24, 2021. It is now read-only.
feat: Hanoi - Add new compose builder options for 1.3.1 - #407
Merged
lenny-goodell merged 2 commits intoFeb 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lenny-goodell
force-pushed
the
hanoi-more-options
branch
from
95b8c5a to
255a374
Compare
February 4, 2021 20:47
Added these options:
- mqtt-bus (renamed from mqtt to be more explicit)
- mqtt-broker (new)
- asc-http (new)
- asc-mqtt (new)
- modbus-sim (new)
Aslo added this to device-grove yaml
```
devices:
- /dev/i2c-1
```
closes #406
Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
hanoi-more-options
branch
from
255a374 to
16084e0
Compare
February 4, 2021 20:48
jim-wang-yutsung
suggested changes
Feb 4, 2021
jim-wang-yutsung
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
just minor changes in documentation if my take is ok
Sorry, something went wrong.
Comment thread
compose-builder/README.md
Outdated
Comment thread
compose-builder/README.md
Outdated
Comment thread
compose-builder/README.md
Outdated
Comment thread
compose-builder/README.md
Outdated
Comment thread
compose-builder/README.md
Outdated
Comment thread
compose-builder/README.md
Outdated
Comment thread
compose-builder/README.md
Outdated
Comment thread
compose-builder/README.md
Outdated
Signed-off-by: lenny <leonard.goodell@intel.com>
jim-wang-yutsung
approved these changes
Feb 4, 2021
jim-wang-yutsung
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jpwhitemn
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/developer-scripts/blob/master/.github/Contributing.md.
What is the current behavior?
Hanoi Compose Builder doesn't have some new options that users requesting
device-grove YML missing devices section
Issue Number: #406
What is the new behavior?
Added these options:
Aslo added this to device-grove yaml
devices: - /dev/i2c-1Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information