Fixed warning for complex perm - #110
Merged
liubenyuan merged 5 commits intoDec 12, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
liubenyuan
reviewed
Dec 10, 2025
liubenyuan
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Could you please also fix the linting error on line 603 of quality/merit.py by replacing np.NaN with np.nan?
Sorry, something went wrong.
Replaced instances of 'NaN' with 'nan' in test cases for consistency.
Copy link
Copy Markdown
Contributor
Author
|
After replacing np.NaN with np.nan one after the other, the linting process runs through. |
Sorry, something went wrong.
liubenyuan
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a complex perm value like perm = 100 + 10j was assigned to an anomaly, the resulting simulated voltages of the forward EIT model were real valued. This is also because of the initialized array in fem.py line 120:
result = np.empty((ex_mat.shape[0], self.kg.shape[0]))
This PR simply changes the data type of the NumPy array to complex.
Finally, the output values for the simulated forward EIT model will be complex.
The following warning will no longer appear:
For the reconstruction algorithms still the following warning will still appear:
ComplexWarning: Casting complex values to real discards the imaginary part
jac[:, e] = np.sum(np.dot(ri[:, ijk], self.se[e]) * f_n[:, ijk], axis=1)