TO BE CLOSED, CHANGES ON TOP OF MASTER - #2
Open
elan-rmaw wants to merge 1 commit into
Open
elan-rmaw wants to merge 1 commit into
elan-rmaw wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
elan-rmaw
force-pushed
the
rm-DS-6670-update-pythonnet
branch
from
00b3610 to
c059e87
Compare
May 19, 2026 13:53
elan-rmaw
marked this pull request as ready for review
May 20, 2026 09:41
elan-rmaw
force-pushed
the
rm-DS-6670-update-pythonnet
branch
from
f7045ad to
2cdcb95
Compare
May 20, 2026 09:44
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
This PR adjusts the runtime iterable wrapper to avoid holding the Python GIL across yield return, and adds a regression test to ensure partial enumeration releases the GIL as expected. It also updates the repository version string.
Changes:
- Release the GIL before yielding items in IterableWrapper<T>.GetEnumerator().
- Add a regression probe (IterableRegressionTester) + pytest covering partial iteration GIL behavior.
- Update version.txt to 3.1.0-rc7+elan.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| version.txt | Updates the build/version string consumed by MSBuild properties. |
| tests/test_codec.py | Adds a pytest regression test for partial iteration not holding the GIL; updates imports. |
| src/testing/IterableRegressionTester.cs | Introduces a small test helper to detect whether the GIL is still held after a partial iteration step. |
| src/runtime/CollectionWrappers/IterableWrapper.cs | Refactors iteration to acquire the GIL only for MoveNext/conversion and release it before yield return. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
version.txt
Comment thread
src/testing/IterableRegressionTester.cs
Outdated
| @@ -0,0 +1,33 @@ | |||
| using System; | |||
elan-rmaw
force-pushed
the
rm-DS-6670-update-pythonnet
branch
from
2cdcb95 to
6c46f3a
Compare
May 20, 2026 12:25
elan-rmaw
force-pushed
the
rm-DS-6670-update-pythonnet
branch
from
877fc69 to
6c46f3a
Compare
May 20, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.