Fix use_ssl: True on Python 3.10 - #1496
Merged
pquentin merged 6 commits intoJun 1, 2022
Merged
pquentin merged 6 commits into
pquentin merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Rally is a client, so its purpose is to authenticate servers. We also add tests for the IP and client certs cases to make sure this change does not break them.
inqueue
approved these changes
May 31, 2022
inqueue
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rally is a client, so its purpose is to authenticate servers. This means
that we should use ssl.Purpose.SERVER_AUTH instead of CLIENT_AUTH, with
or without client certs. This is super confusing, see
python/cpython#73996. Anyway, in 3.10 making this mistake isn't possible
anymore due python/cpython#26646.
To make sure this does not break in the future, we also add tests for
the IP and client certs cases.