FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Skip favicon requests for localhost and loopback referrers by Copilot · Pull Request #404 · electerious/Ackee · GitHub

Skip favicon requests for localhost and loopback referrers - #404

Merged
electerious merged 4 commits into
masterfrom
copilot/fix-localhost-favicon-request
Sep 18, 2026
Merged

electerious merged 4 commits into
masterfrom
copilot/fix-localhost-favicon-request

Conversation

Copilot AI commented Jul 1, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Ackee currently derives referrer favicons from the referrer URL itself, which causes the dashboard to request /favicon.ico from localhost and loopback addresses when those appear as referrers. That can trigger browser prompts about accessing local applications and looks suspicious to operators.

  • UI behavior

    • Route referrer favicon generation through a dedicated helper instead of constructing new URL('/favicon.ico', item.url) inline.
    • Return no favicon URL for local-only referrers:
      • localhost
      • *.localhost
      • 127.0.0.0/8
      • ::1
    • Preserve existing behavior for non-local referrers.
  • Safety boundaries

    • Limit the change to favicon URL generation in the referrers presentation.
    • Do not alter referrer collection, normalization, storage, or API output.
  • Coverage

    • Add focused tests for:
      • public hostnames
      • localhost
      • localhost subdomains
      • IPv4 loopback
      • IPv6 loopback
      • public IPv4 addresses
export default (url) => {
  if (url == null || isLocalHostname(url.hostname)) return

  return new URL('/favicon.ico', url).href
}

vercel Bot commented Jul 1, 2026
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ackee Ready Preview, Comment Jul 1, 2026 8:52am

Copilot AI changed the title [WIP] Fix localhost/favicon.ico call to prevent unauthorized access Skip favicon requests for localhost and loopback referrers Jul 1, 2026
Copilot AI requested a review from electerious July 1, 2026 08:53
electerious marked this pull request as ready for review July 4, 2026 13:26
electerious merged commit 8fd6a73 into master Sep 18, 2026
14 checks passed
electerious deleted the copilot/fix-localhost-favicon-request branch September 19, 2026 11:11

This branch was successfully deployed

1 active deployment
Preview 8fd6a730 Deployed Jul 1, 2026 by vercel[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

localhost/favicon.ico calls trigger browser request to access other apps on the computer

2 participants


Back | FazBrowse Home | New Git URL