Deduplicate source references when merging extracted messages - #441
Merged
maennchen merged 2 commits intoJul 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
maennchen
approved these changes
Jul 29, 2026
Copy link
Copy Markdown
Member
|
@rigzad Thanks for the PR ❤️ |
Sorry, something went wrong.
Two extraction calls that resolve to the same msgid at the same file:line each contribute a reference group, and merge_messages_after_checks/2 concatenates them without uniquing. Macro-generated code produces N calls attributed to a single line, so the same comment is written N times. on the very next line is already uniqued; this makes consistent with it.
maennchen
reviewed
Jul 29, 2026
Comment thread
test/gettext/extractor_test.exs
Co-authored-by: Jonatan Männchen <jonatan@maennchen.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two extraction calls that resolve to the same msgid at the same file:line each contribute a reference group, and merge_messages_after_checks/2 concatenates them without uniquing. Macro-generated code produces N calls attributed to a single line, so the same #: comment is written N times.
extracted_comments on the very next line is already uniqued; this makes references consistent with it.