Fix compile warnings and update CI matrix for latest Elixir/OTP - #180
Closed
gilbertwong96 wants to merge 1 commit into
Closed
Fix compile warnings and update CI matrix for latest Elixir/OTP#180gilbertwong96 wants to merge 1 commit into
gilbertwong96 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Two unrelated maintenance changes: 1. Fix redundant execute_ddl/1 clauses in connection.ex The file had two duplicate sets of execute_ddl/1 clauses: a newer set (with @impl true markers) and an older set of duplicates. The newer Ecto type system flags the duplicates as redundant warnings that fail the build with --warnings-as-errors. Remove the older duplicate clauses, keeping the first (correct) set intact. Also remove one redundant {:drop_if_exists, %Index{concurrently: true}} clause that is fully covered by the wildcard {:_, %Index{concurrently: true}} clause which raises the same ArgumentError. Preserves the original non-duplicate clauses for Constraint and Index rename operations that only existed in the second set. 2. Update CI matrix to Elixir 1.18-1.20 / OTP 27-29 Per the official Elixir/OTP compatibility table (June 2026): - Elixir 1.20: OTP 27-29 (latest) - Elixir 1.19: OTP 26-28 - Elixir 1.18: OTP 25-27 Drops Elixir 1.17 and OTP 26 (both EOL), adds Elixir 1.20 and OTP 29 (latest). Excludes 3 combinations that fall outside the official support ranges. Lint job runs on the latest (1.20+29). 6 valid combinations remain, all within official support ranges.
Copy link
Copy Markdown
Member
|
Hey I appreciate the PR pointing this out. I had to walk this change in myself to validate implementation. I'm working on getting exqlite upgraded as well. Will cut a new release soon. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated maintenance changes bundled together:
1. Fix redundant execute_ddl/1 clauses
mix compile --warnings-as-errors was failing with 11 "redundant clause" warnings, all in lib/ecto/adapters/sqlite3/connection.ex. The file had two duplicate sets of execute_ddl/1 clauses: a newer set (with @impl true markers) and an older set of duplicates.
With the recent Ecto upgrade (commit e408901, "Upgrade ecto_sql and bump version"), the upstream type system became smarter and started flagging the duplicate clauses as redundant. Since CI uses --warnings-as-errors, the build was broken.
Removed 11 duplicate clauses (~100 lines), keeping the first (correct) set intact. Also removed one additional redundant {:drop_if_exists, %Index{concurrently: true}} clause that is fully covered by the wildcard {:_, %Index{concurrently: true}} clause (which raises the same ArgumentError).
The original non-duplicate clauses for Constraint operations and Index rename are preserved.
2. Update CI matrix to Elixir 1.18-1.20 / OTP 27-29
Per the official Elixir/OTP compatibility table (June 2026):
Drops Elixir 1.17 and OTP 26 (both EOL), adds Elixir 1.20 and OTP 29 (latest). 6 valid combinations remain, all within the official support ranges.
Verification