chore: update submodule: eloqstore bug fixs and automatic config of eloqstore disk limits - #239
Conversation
Sorry, something went wrong.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting. Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe PR updates the data_substrate submodule commit reference from aa2703c81b190dd7a41a82e1c1c04170b6c28ffd to 962933b1ca097a155783a02bf360e7a6158a1b98. No API or behavioral changes detected. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem🚥 Pre-merge checks | ✅ 3 ✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches 🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
There was a problem hiding this comment.
concourse/scripts/mtr_bootstrap_ds.cnf (1)🤖 Prompt for all review comments with AI agents15-16: Avoid hardcoding static object-store credentials in repo configs.
Line 15, Line 16, Line 22, and Line 23 commit fixed credentials directly. Even for test MinIO, this weakens secret hygiene and encourages reuse. Prefer injecting these values from CI/environment or a local untracked override file.
Also applies to: 22-23
🤖 Prompt for AI AgentsVerify each finding against the current code and only fix it if needed. In `@concourse/scripts/mtr_bootstrap_ds.cnf` around lines 15 - 16, Remove the hardcoded credentials (aws_access_key_id and aws_secret_key) from the config and replace them with injected values (e.g., reference environment variables or a local untracked override). Update the config entries to read from placeholders like ${MINIO_ACCESS_KEY} and ${MINIO_SECRET_KEY} or document that these should be provided by CI/runtime env; ensure any local developer override file is .gitignored and mention the same change for the other occurrences of aws_access_key_id/aws_secret_key in this diff.
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@concourse/scripts/mtr_bootstrap_ds.cnf`:
- Around line 15-16: Remove the hardcoded credentials (aws_access_key_id and
aws_secret_key) from the config and replace them with injected values (e.g.,
reference environment variables or a local untracked override). Update the
config entries to read from placeholders like ${MINIO_ACCESS_KEY} and
${MINIO_SECRET_KEY} or document that these should be provided by CI/runtime env;
ensure any local developer override file is .gitignored and mention the same
change for the other occurrences of aws_access_key_id/aws_secret_key in this
diff.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📥 CommitsReviewing files that changed from the base of the PR and between b3b5b7d and ddf8c22.
📒 Files selected for processing (6)- concourse/scripts/mtr_bootstrap.cnf
- concourse/scripts/mtr_bootstrap_ds.cnf
- data_substrate
- storage/eloq/mysql-test/mono_basic/data_substrate.cnf
- storage/eloq/mysql-test/mono_main/data_substrate.cnf
- storage/eloq/mysql-test/mono_main/my.cnf
- concourse/scripts/mtr_bootstrap.cnf
- storage/eloq/mysql-test/mono_main/my.cnf
- data_substrate
Sorry, something went wrong.
Summary by CodeRabbit