| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I think we are missing fixture tests for the classic app blueprint. I only updated the addon fixtures, but the tests are all passing. The app version is being skipped here: ember-cli/tests/acceptance/new-test.js Lines 272 to 274 in e2da7a9 That Vite experiment is always enabled at the moment: Do we need new fixture files for the classic app and update the new command so it uses the classic blueprint specifically? Or will that not work in the test setup? |
Sorry, something went wrong.
| @@ -1 +1 @@ | |||
| import '@glint/environment-ember-loose'; | |||
| import '@glint/ember-tsc/types'; | |||
There was a problem hiding this comment.
can we delete this file and move it to the tsconfig's compilerOptions#types?
Sorry, something went wrong.
There was a problem hiding this comment.
thanks for doing this! this is really close -- just one change I'd like to see that brings it closer to the v2 app blueprint
Sorry, something went wrong.
Done. The TS app blueprint still isn't being tested though. Not all fixtures were updated and the tests pass. I poked at it briefly but don't really know the way forward there. Probably best to get the RFC out to deprecate the classic blueprint it so it can be removed in v8 (or earlier since it's not really linked to ember-source) 😄 . |
Sorry, something went wrong.
yeah, ember-cli doesn't fully test blueprints -- which was a huge motivation for pulling blueprints out to their own repos -- so we can spend more ci time on proper tests -- which we haven't had motivation to do with the blueprints we want to deprecate
yea, agreed -- I need to remind myself where this is at -- (ie: ask @mansona ) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Closes #11046