Add include option to add additional coverage to the report - #79
Open
jesseditson wants to merge 1 commit into
Open
Add include option to add additional coverage to the report#79jesseditson wants to merge 1 commit into
jesseditson wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Relates to: ember-cli/rfcs#81 - with that RFC and this PR, tests & coverage would work across both the app and the server code |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
This seems okay to me. @rwjblue @kategengler @kellyselden thoughts? I would definitely like to see some tests added here, but I am not opposed to the idea of this feature. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an include option to the config hash that will allow users to include additional coverage to the output.
My current setup is as follows:
This option allows me to specify the coverage-server/coverage-final.json (generated via nyc), and get accurate coverage on my entire app, instead of having 2 different coverage reports.