This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Adding more to decorator docs - #489
Open
jocho-here wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
aminalaee
reviewed
Jun 10, 2022
Comment thread
docs/connections_and_transactions.md
| ```python | ||
| @router.post("/my-awesome-endpoint") | ||
| @database.transaction() | ||
| async def awesome_endpoint(): |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think it would be better to mention something general that "If using multiple decorators, the @database.transaction() should be the most inner to the function definition. But maybe with better wording 😄
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to find a way to properly use the transaction decorator when using with other decorators in the docs.
I thought it would be helpful to add this portion so others can also be aware they need to put the decorator right above the function signature without going into the code and finding out about it themselves.