feat(stepfunctions): Improve aws stepfunctions support - #202
Conversation
Sorry, something went wrong.
| :return: None | ||
| """ | ||
| _, request_args = args | ||
| try: |
There was a problem hiding this comment.
I don't see why you need this try block as it.
initialize_step_dict already has it, and if you think that the json.loads may be problematic you should except only related errors.
Sorry, something went wrong.
| :param response: response from Step function Client | ||
| :return: None | ||
| """ | ||
| self.resource['metadata']['Response Metadata'] = response.get( |
There was a problem hiding this comment.
What is this field? I don't see it in the documentation.
And I don't think you should save the empty string if it's missing.
Sorry, something went wrong.
| return wrapper(BotocoreEventFactory, wrapped, instance, args, kwargs) | ||
|
|
||
|
|
||
| def initial_steps_dict(request_args, params_property_name): |
There was a problem hiding this comment.
That's not a good name
Sorry, something went wrong.
…t, DescribeExecution, SQS lambda trigger
ronyis
left a comment
There was a problem hiding this comment.
Looks good, but few minor comments remain (see the unresolved ones)
Sorry, something went wrong.
Add support to the following functions: send_task_success, send_task_heartbeat, describe_execution
Add support to step function lambda triggered by SQS