feat(celery.py): add support for celery - #207
Conversation
Sorry, something went wrong.
| from ..utils import add_data_if_needed | ||
| from ..runners.celery import CeleryRunner | ||
|
|
||
| # Stores all events |
There was a problem hiding this comment.
There is a risk of a memory leak here. We should add tests to make sure that it's getting empty whenever any Celery API is used.
Sorry, something went wrong.
| # Check if this is a known driver to update the resource details | ||
| driver_map = self.DRIVER_MAPPING.get(app_conn.transport.driver_type) | ||
| if driver_map: | ||
| self.resource['name'] = app_conn.hostname |
There was a problem hiding this comment.
Sure there isn't a more specific field to use? (Like a 'topic')
Sorry, something went wrong.
There was a problem hiding this comment.
There also "virtual host" I'm not quite sure whether to add it or not, but it is in the metadata if we would like to use it in future.
Sorry, something went wrong.
There was a problem hiding this comment.
OK
Sorry, something went wrong.
| """ | ||
| if 'task_id' in kwargs: | ||
| event_id = kwargs.get('task_id', '') | ||
| sender = kwargs.get('sender').name |
There was a problem hiding this comment.
This can break, and this code is run outside try-except block
Sorry, something went wrong.
There was a problem hiding this comment.
👍
Sorry, something went wrong.
ronyis
left a comment
There was a problem hiding this comment.
See one comment
Sorry, something went wrong.
| # Check if this is a known driver to update the resource details | ||
| driver_map = self.DRIVER_MAPPING.get(app_conn.transport.driver_type) | ||
| if driver_map: | ||
| self.resource['name'] = app_conn.hostname |
There was a problem hiding this comment.
OK
Sorry, something went wrong.
| # Comes from pre and post run, and failure signals | ||
| event_id = kwargs.get('task_id', '') | ||
| sender = kwargs.get('sender').name | ||
| sender = kwargs.get('sender').name if kwargs.get('sender') else '' |
There was a problem hiding this comment.
Well, actually it may still not have a name attribute but up to you if we want to get that strict
Sorry, something went wrong.
No description provided.