FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(main): run epsagon using env var by ranrib · Pull Request #208 · epsagon/epsagon-python · GitHub

This repository was archived by the owner on Jun 13, 2023. It is now read-only.
/ epsagon-python Public archive

feat(main): run epsagon using env var - #208

Merged
ranrib merged 9 commits into
masterfrom
run-as-module
Mar 18, 2020
ConversationCommits (9)ChecksFiles changed
Merged

feat(main): run epsagon using env var#208
ranrib merged 9 commits into
masterfrom
run-as-module

Conversation

ranrib commented Mar 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

In additon - auto-tracing Flask and Django apps.

ranrib requested a review from razlo March 1, 2020 22:00
ranrib self-assigned this Mar 1, 2020
ranrib changed the title feat(__main__.py): run epsagon as a module feat(main): run epsagon as a module Mar 2, 2020
ranrib changed the title feat(main): run epsagon as a module feat(main): run epsagon using env var Mar 3, 2020
ranrib commented Mar 4, 2020
View reviewed changes
Comment thread epsagon/__init__.py
from .handler import wrapper


def auto_load(_):

ranrib Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Check when entry point is being used

ranrib Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

check init twice

ranrib Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

check when AUTOWRAPT_BOOTSTRAP=epsagon called but no Epsagon installed

ranrib Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lock wrapt and autowrapt versions

ranrib Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Make sure we don't auto-trace Tornado twice

ranrib Mar 16, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
  1. Entrypoints are exposing an interface to interact with the code. They are not being called automatically.
  2. If init is being called twice, the later init will take place. If environment variables are supplied they will be the one to be chosen. There should be any problem raised from any relevant scenario.
  3. If Epsagon is not installed but AUTOWRAPT_BOOTSTRAP=epsagon is called - nothing happens.
  4. versions locked
  5. Tornado it being traced in a different way (instrumenting incoming call, and not adding a middleware to the app) - so it can't be done twice

razlo Mar 16, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't see that the versions are locked
forgot to push?

razlo approved these changes Mar 18, 2020
View reviewed changes
Comment thread epsagon/modules/django.py
(EPSAGON_MIDDLEWARE,) + settings.MIDDLEWARE
)
elif isinstance(settings.MIDDLEWARE, list):
settings.MIDDLEWARE = [EPSAGON_MIDDLEWARE] + settings.MIDDLEWARE

razlo Mar 18, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

u can just .append

ranrib merged commit 51092a3 into master Mar 18, 2020
ranrib deleted the run-as-module branch March 18, 2020 17:52

enoodle commented Mar 18, 2020

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
razlo razlo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ranrib

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL