Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Review Summary by Qodo

Remove trailing slash for ESM etherpad compatibility

🐞 Bug fix

Walkthroughs

• Remove trailing slash from eejs require path
• Ensures compatibility with upcoming ESM etherpad
• Maintains backward compatibility with current CJS
• Bump version to 0.0.61

flowchart LR
  A["require with trailing slash"] -- "breaks ESM exports" --> B["ESM etherpad incompatible"]
  C["require without trailing slash"] -- "works with both" --> D["CJS and ESM compatible"]
  A -- "fix applied" --> C

File Changes

Remove trailing slash from eejs require

• Remove trailing slash from require('ep_etherpad-lite/node/eejs/') path
• Change to require('ep_etherpad-lite/node/eejs') for strict ESM exports resolution
• Maintains backward compatibility with current CJS etherpad

eejs.js

Bump version for ESM compatibility fix

• Increment version from 0.0.60 to 0.0.61

package.json

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1)

Description

This PR changes the module resolution path in eejs.js as a bug fix for ESM compatibility, but no
regression test was added or updated to cover the behavior. Without an automated test, the
trailing-slash import can be reintroduced unnoticed and break under strict ESM exports resolution.

Code

eejs.js[3]

Evidence

PR Compliance ID 1 requires a regression test for each bug fix. The PR modifies the require() path
in eejs.js, but the existing automated test only checks that a pad loads and does not exercise or
guard the require('ep_etherpad-lite/node/eejs') import string against regression.

AGENTS.md: Every Bug Fix Must Include a Regression Test
eejs.js[3-3]
static/tests/frontend-new/specs/smoke.spec.ts[8-13]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A bug fix was made to remove the trailing slash from `require('ep_etherpad-lite/node/eejs/')`, but there is no regression test to prevent reintroducing the trailing-slash form.

## Issue Context
The change in `eejs.js` is intended to maintain backward compatibility while working with Node's strict ESM exports map resolution.

## Fix Focus Areas
- eejs.js[3-3]
- static/tests/backend/specs/esm-eejs-require.spec.js[1-120]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools