Lite version - #64
Open
ChocolateFrogsNuts wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Code optimisations and changes to make it possible to use a "Lite" version. If using CLK6/7 this will cut the compiled size by almost 2K. If you don't need CLK6/7 the compiled size can be reduced a further 2K.
Forgot to include the header in the last commit
MedadRufus
reviewed
Jun 3, 2022
Comment thread
src/si5351.h
Comment on lines
+36
to
+52
| //#define SI5351_WITH_CLK67 0 | ||
|
|
||
| #ifndef SI5351_WITH_CLK67 | ||
| #define SI5351_WITH_CLK67 1 | ||
| #endif | ||
| #ifndef SI5351_WITH_NEW | ||
| #define SI5351_WITH_NEW 0 | ||
| #endif | ||
|
|
||
| /* Define definitions */ | ||
|
|
||
| #if WITH_CLK67 | ||
| #define SI5351_CLK_LAST SI5351_CLK7 | ||
| #else | ||
| #define SI5351_CLK_LAST SI5351_CLK5 | ||
| #endif | ||
|
|
Copy link
Copy Markdown
There was a problem hiding this comment.
Do we really need to set 2 seperate flags(SI5351_WITH_CLK67, WITH_CLK67) and to indicate that there are clocks 6 and 7? It can be a single flag I think.
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
I think WITH_CLK67 should change to SI5351_WITH_CLK67.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Definitely a useful improvement, especially when running on resource constrained platforms like the ATmega328p. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally got around to doing a pull request for this!
Code optimisations and changes to make it possible to use a "Lite" version.
If using CLK6/7 this will cut the compiled size by almost 2K.
If you don't need CLK6/7 the compiled size can be reduced a further 2K.