Adds capability for the feed command, to specify index - #501
Open
ottpeter wants to merge 8 commits into
Open
ottpeter wants to merge 8 commits into
ottpeter wants to merge 8 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ottpeter
marked this pull request as ready for review
May 23, 2024 14:05
aranyia
reviewed
May 23, 2024
Comment thread
src/command/feed/feed-command.ts
Outdated
| @Option({ key: 'password', alias: 'P', description: 'Password for the wallet' }) | ||
| public password!: string | ||
|
|
||
| @Option({ key: 'index', description: 'Index for the feed to write to, or read from', required: false }) |
Copy link
Copy Markdown
There was a problem hiding this comment.
Maybe it could simply say "Feed index to write to or read from"?
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Good idea. I'll make this change.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds capability for the feed command, to specify index, when doing read or write.