Add data closure to the cycle_callback of deferred response - #145
Merged
etr merged 4 commits intoFeb 11, 2019
Merged
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 96.46% 96.55% +0.09%
==========================================
Files 34 34
Lines 2995 3019 +24
==========================================
+ Hits 2889 2915 +26
+ Misses 106 104 -2
Continue to review full report at Codecov.
|
Sorry, something went wrong.
This was referenced Feb 11, 2019
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change adds a data closure that is passed through the cycle_callback of a deferred response.
Alternate Designs
A couple of pull requests have been proposed to tackle this:
Possible Drawbacks
This adds a template to the deferred_response effectively complicating the interface.
Verification Process
Performed tests on travis.
Release Notes
It is now possible to pass a data closure through the cycle_callback of a deferred response.