FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simplify libmicrohttpd dependency configuration by etr · Pull Request #223 · etr/libhttpserver · GitHub

Simplify libmicrohttpd dependency configuration - #223

Merged
etr merged 2 commits into
masterfrom
simplify_dependency
Mar 2, 2021
Merged

Simplify libmicrohttpd dependency configuration#223
etr merged 2 commits into
masterfrom
simplify_dependency

Conversation

etr commented Mar 2, 2021

Copy link
Copy Markdown
Owner

Description of the Change

Removes compilation options to manage usage of select/poll/epoll. The code now makes use of MHD_USE_AUTO flag internally which automatically decides the best dispatch method.

Alternate Designs

Keep the current custom implementation. The downside would be that the configuration is more complex and error prone.

Possible Drawbacks

Performance issues. These have been verified in local and will be further verified as part of the validation process in github actions.

The change also requires a bump in the minimum required version of libmicrohttpd (from 0.9.52 to 0.9.53) - this is a minor version only so the issue should be minimal.

Verification Process

Manual validation through unit testing + local performance testing using apache benchmark (no visible improvement nor degradation of performance). Additional validation will be performed through github actions.

Release Notes

The package now does not require configuration flags to manage the internal dispatch method (poll/epoll/select).

etr added the build-system Related to the build system. label Mar 2, 2021
etr self-assigned this Mar 2, 2021
etr changed the title Simplify dependency Simplify libmicrohttpd dependency configuration Mar 2, 2021
etr merged commit b7ae750 into master Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-system Related to the build system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL