FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: sanitizer handling extra statements outside the function to complete by Co1lin · Pull Request #189 · evalplus/evalplus · GitHub

fix: sanitizer handling extra statements outside the function to complete - #189

Merged
ganler merged 2 commits into
evalplus:masterfrom
Co1lin:master
May 4, 2024
Merged

fix: sanitizer handling extra statements outside the function to complete#189
ganler merged 2 commits into
evalplus:masterfrom
Co1lin:master

Conversation

Co1lin commented May 4, 2024

Copy link
Copy Markdown
Contributor

Fix #188

Co1lin marked this pull request as draft May 4, 2024 04:05

Co1lin commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

The first case in the issue can be fixed by this commit.
For the second one I tried this, but I'm not sure. In my understanding, if a definition node is not a dependency of the entrypoint, we should not add it. The condition not (name in variable_names) should be removed.

Co1lin marked this pull request as ready for review May 4, 2024 04:15

ganler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thank you @Co1lin

ganler merged commit b297bb9 into evalplus:master May 4, 2024

ganler commented May 4, 2024

Copy link
Copy Markdown
Member

Would also be nice if you can submit another PR to add a test case at: https://github.com/evalplus/evalplus/blob/master/tests/test_treesitter_sanitizer.py

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] sanitizer cannot handle additional statements

2 participants


Back | FazBrowse Home | New Git URL