Reviewer's Guide

Introduz um mecanismo de cache e bloqueio em createConversation para evitar conversas duplicadas, reorganiza o fluxo de obtenção e atualização de contatos e grupos, refatora a busca/criação de conversas incluindo lógica de reopenConversation e conversationPending, e remove trechos redundantes de código, com logs mais claros.

Sequence Diagram: Concurrent createConversation Handling

sequenceDiagram
    participant Requester1
    participant Requester2
    participant ChatwootService
    participant Cache

    Requester1->>ChatwootService: createConversation(remoteJid)
    ChatwootService->>Cache: has(convCacheKey_remoteJid)  // Check if conversation already cached
    Cache-->>ChatwootService: false
    ChatwootService->>Cache: has(lockKey_remoteJid)     // Check if operation is locked
    Cache-->>ChatwootService: false
    ChatwootService->>Cache: set(lockKey_remoteJid, true) // Requester1 acquires lock
    Note over ChatwootService, Cache: Lock acquired by Requester1

    Requester2->>ChatwootService: createConversation(remoteJid) // Concurrent request for same remoteJid
    ChatwootService->>Cache: has(convCacheKey_remoteJid)
    Cache-->>ChatwootService: false
    ChatwootService->>Cache: has(lockKey_remoteJid)
    Cache-->>ChatwootService: true // Lock is active, held by Requester1
    Note over ChatwootService: Requester2 starts waiting/polling period

    activate ChatwootService
    Note left of ChatwootService: Requester1 processing
    ChatwootService->>ChatwootService: Perform actual conversation creation/retrieval
    ChatwootService->>Cache: set(convCacheKey_remoteJid, conversationId) // Cache the created conversationId
    ChatwootService->>Cache: delete(lockKey_remoteJid) // Requester1 releases lock
    ChatwootService-->>Requester1: conversationId
    deactivate ChatwootService
    Note over ChatwootService, Cache: Lock released by Requester1, conversationId cached

    activate ChatwootService
    Note left of ChatwootService: Requester2's polling finds change
    ChatwootService->>Cache: has(convCacheKey_remoteJid) // Requester2 checks cache during its wait
    Cache-->>ChatwootService: true // ConversationId found in cache
    ChatwootService->>Cache: get(convCacheKey_remoteJid)
    Cache-->>ChatwootService: conversationId
    ChatwootService-->>Requester2: conversationId (from cache)
    deactivate ChatwootService

Class Diagram: ChatwootService Update for createConversation

classDiagram
  class ChatwootService {
    -cache: CacheProvider
    -logger: LoggerProvider
    +createConversation(instance: InstanceDto, body: any): Promise<number | null>
  }
  note for ChatwootService "The createConversation method is updated to include caching and a locking mechanism to prevent duplicate conversation creations. It utilizes the 'cache' member for these operations."

File-Level Changes

Possibly linked issues

• #0: The PR prevents duplicate conversations in Chatwoot by adding a lock to the creation method, addressing the issue.

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

@sourcery-ai resolve

Essa correção de duplicidade de conversas vai ajudar muito!