FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

(mysql): remove out-of-order wavoipToken migration by pauloboc · Pull Request #1664 · evolution-foundation/evolution-api · GitHub

/ evolution-api Public

(mysql): remove out-of-order wavoipToken migration - #1664

Merged
DavidsonGomes merged 1 commit into
evolution-foundation:developfrom
pauloboc:fix-setup-mysql
Jul 1, 2025
ConversationCommits (1)ChecksFiles changed
Merged

(mysql): remove out-of-order wavoipToken migration#1664
DavidsonGomes merged 1 commit into
evolution-foundation:developfrom
pauloboc:fix-setup-mysql

Conversation

pauloboc commented Jun 28, 2025 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Contributor

Delete prisma/mysql-migrations/1707735894523_add_wavoip_token_to_settings_table, which executes before the initial Setting table is created and breaks fresh MySQL installs.

The later migration 20250214181954_add_wavoip_token_column, line 145, already adds the column correctly, so keeping only that directory guarantees a clean deploy.

Summary by Sourcery

Remove the out-of-order wavoipToken migration to prevent fresh MySQL installs from breaking and rely solely on the correct later migration for a clean deployment.

Bug Fixes:

  • Delete the obsolete 1707735894523_add_wavoip_token_to_settings_table migration that ran before the Settings table existed and caused fresh install failures.

Chores:

  • Remove the unused prisma/mysql-migrations/1707735894523_add_wavoip_token_to_settings_table directory

(mysql): remove out-of-order wavoipToken migration
287c679 
Delete prisma/mysql-migrations/1707735894523_add_wavoip_token_to_settings_table, which executes before the initial Setting table is created and breaks fresh MySQL installs.

The later migration 20250214181954_add_wavoip_token_column, line 145, already adds the column correctly, so keeping only that directory guarantees a clean deploy.

sourcery-ai Bot commented Jun 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Eliminates the early wavoipToken migration that ran before the Settings table existed, relying instead on the later migration which correctly adds the column to ensure clean fresh MySQL installs.

File-Level Changes

Change Details Files
Remove outdated wavoipToken migration that caused installation failures
  • Delete the 1707735894523_add_wavoip_token_to_settings_table directory
  • Remove its migration SQL file
 prisma/mysql-migrations/1707735894523_add_wavoip_token_to_settings_table/migration.sql
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai Bot reviewed Jun 28, 2025
View reviewed changes

sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey @pauloboc - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨ Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

DavidsonGomes changed the base branch from main to develop July 1, 2025 11:14
DavidsonGomes merged commit 53101d4 into evolution-foundation:develop Jul 1, 2025
pauloboc deleted the fix-setup-mysql branch July 2, 2025 20:21
augustresende mentioned this pull request Aug 17, 2025
Closed

augustresende commented Aug 17, 2025

Copy link
Copy Markdown

#1805

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL