FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: correct the error of hardcoded prisma/kafka schema by DavidMenezesDev · Pull Request #2083 · evolution-foundation/evolution-api · GitHub

/ evolution-api Public

fix: correct the error of hardcoded prisma/kafka schema - #2083

Merged
DavidsonGomes merged 1 commit into
evolution-foundation:developfrom
DavidMenezesDev:main
Oct 15, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fix: correct the error of hardcoded prisma/kafka schema#2083
DavidsonGomes merged 1 commit into
evolution-foundation:developfrom
DavidMenezesDev:main

Conversation

DavidMenezesDev commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

📋 Description

🔗 Related Issue

Closes #(2069)

🧪 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧹 Code cleanup
  • 🔒 Security fix

🧪 Testing

  • Manual testing completed
  • Functionality verified in development environment
  • No breaking changes introduced
  • Tested with different connection types (if applicable)

📸 Screenshots (if applicable)

✅ Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have manually tested my changes thoroughly
  • I have verified the changes work with different scenarios
  • Any dependent changes have been merged and published

📝 Additional Notes

Summary by Sourcery

Bug Fixes:

  • Remove "public." prefix from CREATE TABLE, CREATE INDEX, and ALTER TABLE statements in Kafka migration.sql

sourcery-ai Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the PostgreSQL migration script for Kafka integration by removing explicit “public” schema qualifiers and relying on unqualified table names for CREATE TABLE, index, and foreign key definitions.

File-Level Changes

Change Details Files
Remove hardcoded “public” schema qualifiers in Kafka migration SQL
  • Drop “public” prefix from CREATE TABLE statement
  • Remove schema qualification in CREATE UNIQUE INDEX
  • Adjust ALTER TABLE foreign key to reference unqualified Kafka and Instance tables
 prisma/postgresql-migrations/20250918182355_add_kafka_integration/migration.sql

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai Bot reviewed Oct 13, 2025
View reviewed changes

sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey there - I've reviewed your changes - here's some feedback:

  • Add a down migration or in-place rename logic so existing deployments of the "public.Kafka" table aren’t orphaned when this schema correction runs.
  • Consider making the schema name configurable via environment or Prisma settings instead of hardcoding to support non-public schemas.
  • Ensure all other migrations and model definitions have had their schema qualifications updated consistently to avoid mismatches.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- Add a down migration or in-place rename logic so existing deployments of the "public.Kafka" table aren’t orphaned when this schema correction runs.
- Consider making the schema name configurable via environment or Prisma settings instead of hardcoding to support non-public schemas.
- Ensure all other migrations and model definitions have had their schema qualifications updated consistently to avoid mismatches.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨ Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

DavidsonGomes merged commit 9edd600 into evolution-foundation:develop Oct 15, 2025
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL