FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bugfix/media upload failed on all hosts by JefersonRamos · Pull Request #2240 · evolution-foundation/evolution-api · GitHub

/ evolution-api Public

Bugfix/media upload failed on all hosts - #2240

Merged
DavidsonGomes merged 11 commits into
evolution-foundation:developfrom
E-inov:bugfix/media-upload-failed-on-all-hosts
Dec 5, 2025
ConversationCommits (11)ChecksFiles changed
Merged

Bugfix/media upload failed on all hosts#2240
DavidsonGomes merged 11 commits into
evolution-foundation:developfrom
E-inov:bugfix/media-upload-failed-on-all-hosts

Conversation

JefersonRamos commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

📋 Description

Correção no uso de proxy socks dentro do axios

🔗 Related Issue

Closes #(issue_number)

🧪 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧹 Code cleanup
  • 🔒 Security fix

🧪 Testing

  • Manual testing completed
  • Functionality verified in development environment
  • No breaking changes introduced
  • Tested with different connection types (if applicable)

📸 Screenshots (if applicable)

✅ Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have manually tested my changes thoroughly
  • I have verified the changes work with different scenarios
  • Any dependent changes have been merged and published

📝 Additional Notes

sourcery-ai Bot commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🧙 Sourcery has finished reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai Bot reviewed Nov 19, 2025
View reviewed changes

sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey there - I've reviewed your changes - here's some feedback:

  • Consider refactoring the duplicated protocol constants and agent‐selection switch logic into a shared helper to avoid code duplication between makeProxyAgent and makeProxyAgentUndici.
  • selectProxyAgent adds socks5 support but doesn’t handle socks4 protocol—add PROXY_SOCKS4_PROTOCOL and a case for it for consistency with makeProxyAgentUndici.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- Consider refactoring the duplicated protocol constants and agent‐selection switch logic into a shared helper to avoid code duplication between makeProxyAgent and makeProxyAgentUndici.
- selectProxyAgent adds socks5 support but doesn’t handle socks4 protocol—add PROXY_SOCKS4_PROTOCOL and a case for it for consistency with makeProxyAgentUndici.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨ Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

github-advanced-security AI found potential problems Nov 19, 2025
View reviewed changes
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
github-advanced-security AI found potential problems Nov 19, 2025
View reviewed changes
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
Comment thread src/utils/makeProxyAgent.ts Fixed
DavidsonGomes changed the base branch from main to develop November 19, 2025 20:45

DavidsonGomes commented Nov 19, 2025

Copy link
Copy Markdown
Member

Please fix the conflicts, OK?

Jeferson-Ramos-Einov and others added 4 commits November 24, 2025 13:58
Merge remote-tracking branch 'upstream/develop' into bugfix/media-upl…
1c61116 
…oad-failed-on-all-hosts

# Conflicts:
#	package-lock.json
#	src/utils/makeProxyAgent.ts
socks5 update
af47b85
lint
879bee9
lint
5c58cb7

JefersonRamos commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Por favor, resolvam os conflitos, ok?

@DavidsonGomes Conflitos resolvidos, agora as proxies do tipo socks devem funcionar corretamente!

DavidsonGomes merged commit 8d5c7d8 into evolution-foundation:develop Dec 5, 2025
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL