Reviewer's Guide

Refactors the Meta WhatsApp Business webhook flow to compute a per-request sender JID and thread it through the event handling pipeline, removing reliance on a mutable instance field and awaiting the handler to avoid race conditions between concurrent webhook requests.

Sequence diagram for updated Meta WhatsApp webhook sender identification

sequenceDiagram
  participant MetaWebhook as MetaWebhook
  participant BusinessStartupService as BusinessStartupService
  participant EventHandler as eventHandler
  participant MessageHandle as messageHandle

  MetaWebhook->>BusinessStartupService: inboundWebhook(content)
  BusinessStartupService->>BusinessStartupService: loadChatwoot()
  BusinessStartupService->>BusinessStartupService: senderJid = createJid(from or recipient_id)
  BusinessStartupService->>BusinessStartupService: phoneNumber = senderJid
  BusinessStartupService->>EventHandler: eventHandler(content, senderJid)
  activate EventHandler
  EventHandler->>EventHandler: database = get DATABASE
  EventHandler->>EventHandler: settings = findSettings()
  alt content has messages
    EventHandler->>MessageHandle: messageHandle(content, database, settings, senderJid)
  else content has statuses
    EventHandler->>MessageHandle: messageHandle(content, database, settings, senderJid)
  end
  deactivate EventHandler
  MessageHandle->>MessageHandle: key.remoteJid = senderJid
  MessageHandle->>MessageHandle: key.fromMe = (senderJid === metadata.phone_number_id)

Updated class diagram for BusinessStartupService event handling

classDiagram
  class ChannelStartupService

  class Database

  class BusinessStartupService {
    - phoneNumber string
    + eventHandler(content any, senderJid string) void
    + messageHandle(received any, database Database, settings any, senderJid string) void
  }

  BusinessStartupService --|> ChannelStartupService
  BusinessStartupService ..> Database

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

same problem here, merge this!

This bug fix for the race condition in Business API sender identification has been waiting 18 days without a reviewer assigned. Race conditions can cause hard-to-reproduce issues in production — could a maintainer assign a reviewer or take a look when bandwidth allows?

Olá, equipe!

Este PR corrige uma race condition no Business API sender ID da integração com Meta — um problema de alta criticidade que pode causar comportamentos imprevisíveis em ambientes com alta concorrência.

Após 18 dias sem revisão, solicitamos atenção prioritária:

• Atribuição de revisor: este PR merece revisão urgente dada a natureza da correção;
• Impacto em produção: race conditions deste tipo podem afetar a confiabilidade das mensagens enviadas via Business API;
• O autor (@LeonardPeixoto) está disponível para fornecer contexto adicional se necessário.

Escalando para revisão prioritária. Obrigado!