| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Reviewer's guide (collapsed on small PRs)
Reviewer's GuideReuse existing WhatsApp group metadata cache instead of performing an extra round-trip before group sends, while preserving cache-miss behavior. Sequence diagram for WhatsApp group resolution using cached metadatasequenceDiagram
participant BaileysStartupService
participant GroupMetadataCache
loop jids_groups
BaileysStartupService->>GroupMetadataCache: getGroupMetadataCache(jid)
alt [cache hit]
BaileysStartupService-->>BaileysStartupService: new OnWhatsAppDto(jid, true, number)
else [cache miss]
BaileysStartupService-->>BaileysStartupService: new OnWhatsAppDto(jid, false, number)
end
end
File-Level Changes
Tips and commands Interacting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sorry, something went wrong.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
Please address the comments from this code review:
## Overall Comments
- In the groups resolution path, replacing `findGroup({ groupJid: jid }, 'inner')` with `getGroupMetadataCache(jid)` changes behavior on cache misses; consider adding a fallback to the previous resolution logic (or explicitly ensuring cache population before this call) to avoid false negatives when metadata isn't yet cached.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary\n- reuse the existing group metadata cache during WhatsApp group resolution\n- remove the redundant groupMetadata round-trip before group sends\n- preserve existing cache-miss validation and cache population behavior\n\n## Validation\n- npm run db:generate\n- npm run build\n- npm run lint:check -- --no-fix\n- targeted group-cache guard and git diff --check
Summary by Sourcery
Bug Fixes: