| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
Sorry, something went wrong.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 02be33e9-ec18-4cb0-ba12-b215a0c46c64 📥 CommitsReviewing files that changed from the base of the PR and between c0bc141 and 14af6f0. ⛔ Files ignored due to path filters (9)
📝 Walkthrough WalkthroughThis pull request coordinates a version promotion across multiple Go modules in the project. The dependency github.com/evstack/ev-node/core is updated from the prerelease version v1.0.0-rc.1 to the stable version v1.0.0. Simultaneously, local replace directives that pointed ev-node/core to local filesystem paths are removed, transitioning module resolution from development overrides to the official module proxy. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem🚥 Pre-merge checks | ✅ 2 | ❌ 1 ❌ Failed checks (1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches 🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
|
Claude finished @julienrbrt's task in 1m 14s —— View job Code Review: build(deps): bump core v1.0.0
SummaryThis PR promotes github.com/evstack/ev-node/core from v1.0.0-rc.1 to the stable v1.0.0 release across all 9 go.mod files in the monorepo. The primary structural change beyond the version bump is the removal of all local replace directives pointing github.com/evstack/ev-node/core to the local ./core directory. What Changed
ObservationsCorrect and clean change. The removals of replace directives are the expected outcome of graduating core to a stable published release. All 9 modules are updated consistently. One thing worth noting: The ./core directory still lives in the monorepo, but no module now has a local replace pointing to it. This means any in-progress local changes to ./core will be invisible to builds — the published v1.0.0 will be used instead. This is intentional for a stable release, but it does add friction if core ever needs a patch alongside changes in the main module during development. The team would need to temporarily re-add the replace directives in that case (as was done during rc development). Consistency across modules: All modules that previously had replace github.com/evstack/ev-node/core => <path> have had those directives removed. No stragglers. Note on execution/grpc and test/docker-e2e: These modules don't have a replace for the main ev-node module either (they reference v1.0.0-rc.4 as a real dependency), which is a pre-existing pattern not introduced here. Buf CI passed, confirming no protobuf breaking changes in core v1.0.0. VerdictThis is a clean, mechanical dependency promotion. The changes are correct and consistent. No issues found. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3135 +/- ##
==========================================
- Coverage 60.87% 60.81% -0.06%
==========================================
Files 113 113
Lines 11695 11695
==========================================
- Hits 7119 7112 -7
- Misses 3773 3778 +5
- Partials 803 805 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
* main: chore: minor deduplication (#3139) refactor(store,cache)!: optimize cache restore as O(1) (#3134) ci: remove spamoor results from benchmark results per PR (#3138) build(deps): Bump rollup from 4.22.4 to 4.59.0 in /docs in the npm_and_yarn group across 1 directory (#3136) fix(block): fix blocktime timer usage (#3137) build(deps): bump core v1.0.0 (#3135)
| Back | FazBrowse Home | New Git URL |
Bump to core v1
Summary by CodeRabbit