✅ Rendering Bug Fixes — Verified

Latest commit (b5cd6e6) fixes all rendering/formatting issues found in review:

Fixed Issues

Screenshots (after fixes, with realistic sample data)

Event Notice — single clean message, no branch concatenation, no extra HR before first field
Password Reset — "from which" correct spacing
Organization Notice — "to continue", "to see" correct
Organization Invited — "? Exceptionless" with proper space
Daily Summary — MostFrequent + Newest lists, [REGRESSED] badge

Tests

Lint/Type Check

Dogfood Evidence — Mailpit Email Renders

All 8 templates sent to Mailpit via SMTP and visually verified. HTML Check scores range 87–94%.

Bug Found & Fixed: IsRegressed badge was never rendering

Root cause: GetStackTemplateData() in Mailer.cs returned the stack data without IsRegressed, so {{#if IsRegressed}}[REGRESSED]{{/if}} always evaluated false. The badge silently never appeared for regressed stacks — in main or in this PR until caught.

Fix: Added IsRegressed = s.Status == StackStatus.Regressed to GetStackTemplateData().

Proof it works (visible in daily summary email — see screenshot): the [REGRESSED] prefix appears on ArgumentNullException in the Most Frequent list.

Coverage Gap Fixed

RunMailJobAsync() in MailerTests.cs only logged the rendered body — zero assertions. All 25 tests would pass even if templates rendered empty HTML or left {{token}} placeholders unsubstituted.

Fix:

• RunMailJobAsync() now returns string body
• Each of the 26 tests (25 existing + 1 new) asserts template-specific content
• New SendProjectDailySummaryWithRegressedStackAsync verifies [REGRESSED] badge

dotnet test -- --filter-class Exceptionless.Tests.Mail.MailerTests
# total: 26 | failed: 0 | succeeded: 26

Email Renders (new Svelte 5 + Tailwind templates)

Verified via Mailpit at http://localhost:8025 after npm run build in src/Exceptionless.EmailTemplates:

📸 Visual Comparison: All 8 Templates (Before → After)

All templates rendered in Mailpit with identical sample data. Left = main branch (Foundation/Inky), Right = PR (Svelte 5 + Tailwind).

Email Verify

Password Reset

Event Notice

Daily Summary

Note: Both templates show the [REGRESSED] badge because the bug fix in this PR now passes IsRegressed correctly from Mailer.cs. Before this PR, the badge was silently suppressed on main branch despite the template supporting it.

Organization Added

Organization Invited

Organization Notice (Throttled)

Payment Failed

Verification: All 16 emails (8 OLD + 8 NEW) successfully delivered to Mailpit SMTP. All 26 mailer tests pass. 🟢

Follow-up reviewer audit complete at 270cbfa974777fb3b6a80c23732bb5ca050d4419.

I re-read all live review threads, inline comments, submitted reviews, and issue comments against the current branch-vs-main diff. The 18 review threads classify as 14 outdated/already-fixed or superseded-by-the-current implementation and 4 current/already-addressed. One previously resolved human finding had regressed: .gstack/ was removed in response to review, then reintroduced later by 07dbfb878. I removed that unrelated ignore entry again and replied on the original thread with the commit-level RCA and proof.

The thermo-nuclear pass found one additional real boundary gap: parity validation compared visible text and links but did not inspect Gmail application/ld+json actions, so structured-data actions could drift without failing the gate. The validator now parses and exact-compares every JSON-LD document between legacy and modern output. I also removed a redundant CI build step because validate:parity already performs the build.

Verification:

• npm run lint — passed
• npm run check — 0 errors, 0 warnings
• npm run validate:parity -- --semantic-only — 13/13 templates; text, links, and JSON-LD exact
• npm run validate:parity — 13/13 semantic checks plus all 26 desktop/mobile pixel comparisons exact
• npm run build-storybook — passed
• npm audit --omit=dev and npm audit — 0 vulnerabilities
• dotnet test tests/Exceptionless.Tests/Exceptionless.Tests.csproj --no-restore -- --filter-class Exceptionless.Tests.Mail.MailerTests — 27/27 passed
• git diff --check — passed
• replacement CI run — email templates, client, E2E/Aspire, container build, version, and CLA passed; full API test/coverage result recorded by the run

No remaining actionable review concern or external blocker was found. The complete structural pass found no >1,000-line source file, unsafe boundary/type leak, duplicated canonical helper, non-atomic update, or clear behavior-preserving broad refactor beyond the focused CI simplification above.

Addressed the invitation feedback and audited every internal email URL against the Svelte UI.

The organization invitation does not provision an account or password-reset token, so a setup-password page would be the wrong contract. A genuinely new address now follows the invitation email directly to /signup?token=...; if that address has acquired an account before the invitation is accepted, /login?token=... now preserves the token through password and OAuth login and sends it to the API so organization membership is completed. Direct organization links also retain the organization from the URL.

I migrated the remaining legacy email routes to their Svelte equivalents and extended parity validation to discover SvelteKit routes and verify both clean URLs and the current /next deployment prefix.

Verification at 73b07ce9b:

• focused invitation E2E: 2/2 passed (new signup and existing-account login)
• ClientApp build, full npm run validate, and focused auth unit tests passed
• email lint/check passed
• all 13 semantic parity scenarios passed
• all 26 desktop/mobile comparisons are exact pixel matches
• every internal email link maps to a real Svelte route under /next
• email package audit: 0 vulnerabilities

Dependencies were updated to the latest compatible releases; remaining outdated entries are major-version upgrades and were intentionally left for separate compatibility work.

Replacement CI is fully green at 73b07ce9b: API/coverage, client, email templates, full E2E, container build, version, and CLA all passed. Run: https://github.com/exceptionless/Exceptionless/actions/runs/30580372048