FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix regression processing and 5xx recovery by niemyjski · Pull Request #2497 · exceptionless/Exceptionless · GitHub

/ Exceptionless Public

Fix regression processing and 5xx recovery - #2497

Open
niemyjski wants to merge 9 commits into
mainfrom
feature/darren-feedback-followups
ConversationCommits (9)ChecksFiles changed
Open

Fix regression processing and 5xx recovery#2497
niemyjski wants to merge 9 commits into
mainfrom
feature/darren-feedback-followups

Conversation

niemyjski commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Continue fixed-stack regression processing when an earlier stack has no regression candidate.
  • Treat all API 5xx responses as unavailable while preserving the original destination for recovery.
  • Add focused regression coverage for both behaviors.

User impact

One non-regressing stack no longer prevents later stacks in the same batch from being marked as regressed. API failures across the full 5xx range now use the existing service-status recovery flow.

Verification

  • Exact head: 236b244aa7413c58d09dbdde7b6b40838c994d53
  • Base: origin/main at 24d6ad72a6659eec918c4655b531c099208912da; branch is 0 commits behind
  • dotnet build --no-restore - passed with 0 warnings and 0 errors
  • npm run test:unit -- src/lib/features/status/service-status-redirect.test.ts - 14 tests passed
  • npm run validate - formatting, Svelte checks, and ESLint passed
  • npm run build - production build passed
  • dotnet test tests/Exceptionless.Tests/Exceptionless.Tests.csproj --no-restore -- --filter-class Exceptionless.Tests.Pipeline.CheckForRegressionActionTests - passed
  • git diff --check - passed
  • GitHub Actions on the exact head - API/coverage, client, Playwright E2E, Docker build, version, and CLA passed

Review

  • Thermo-nuclear maintainability review against origin/main...HEAD - no blocking findings
  • Standards review - 0 findings
  • Spec review - 0 findings; three-part test naming, Arrange/Act/Assert, direct AppOptions construction, and saved-view prompt removal confirmed
  • Final PR diff contains no saved-view dialog, guard, query-history, Storybook, or saved-view E2E changes

Notes

The proposed saved-view navigation prompt was removed from this PR after team review. Date-filter persistence, deletion refresh, memory formatting, tag overflow, and saved column widths were already implemented on main and are not reimplemented here. Event-count parity still requires an agreed event-type scope because the new All Events view includes session and feature events. Hosted availability and chat acknowledgement remain infrastructure/provider-side verification gates.

niemyjski force-pushed the feature/darren-feedback-followups branch from 6ab0b59 to fd749a8 Compare August 19, 2026 03:29
niemyjski marked this pull request as ready for review August 19, 2026 03:31
chatgpt-codex-connector Bot reviewed Aug 19, 2026
View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd749a81b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ...ess.Web/ClientApp/src/lib/features/saved-views/components/saved-view-navigation-guard.svelte Outdated
chatgpt-codex-connector Bot reviewed Aug 19, 2026
View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24fe0e5c22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ...ess.Web/ClientApp/src/lib/features/saved-views/components/saved-view-navigation-guard.svelte Outdated
chatgpt-codex-connector Bot reviewed Aug 19, 2026
View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56d86e1237

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ...ess.Web/ClientApp/src/lib/features/saved-views/components/saved-view-navigation-guard.svelte Outdated
chatgpt-codex-connector Bot reviewed Aug 19, 2026
View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f27306f4c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ...ess.Web/ClientApp/src/lib/features/saved-views/components/saved-view-navigation-guard.svelte Outdated
chatgpt-codex-connector Bot reviewed Aug 19, 2026
View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19db9598aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ...Exceptionless.Web/ClientApp/src/lib/features/saved-views/components/saved-view-picker.svelte Outdated
Comment thread ...ess.Web/ClientApp/src/lib/features/saved-views/components/saved-view-navigation-guard.svelte Outdated
niemyjski changed the title Fix saved view navigation and feedback regressions Fix regression processing and 5xx recovery Aug 19, 2026

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

Package Line Rate Branch Rate Complexity Health
Exceptionless.Insulation 37% 35% 286 ❌
Exceptionless.Core 75% 67% 10184 ✔
Exceptionless.Web 85% 69% 7903 ✔
Exceptionless.AppHost 38% 41% 147 ❌
Summary 78% (25156 / 32154) 67% (11808 / 17554) 18520 ✔

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL