strings - Expand concept by newline and text blocks - #2941
Conversation
Sorry, something went wrong.
|
Not sure if system dependent newlines are too much information for this concept? I've looked at how other tracks are testing multi-line strings. Elixir uses highschool sweetheart, which asks you to print a multi-line ascii heart. but I'd rather not swap out the whole exercise. Maybe tell the students that the system should be able to produce a "fancy" message with the log level? logLevelMessage("warning");
=>
┌───
│ Exercism Log System
│ Level: warning
└───
|
Sorry, something went wrong.
kahgoh
left a comment
There was a problem hiding this comment.
Sorry for taking so long to get to this one! I like the addition to the about.md.
I've looked at how other tracks are testing multi-line strings. Elixir uses highschool sweetheart, which asks you to print a multi-line ascii heart. but I'd rather not swap out the whole exercise.
Maybe tell the students that the system should be able to produce a "fancy" message with the log level?
The problem with adding another task to the exercise is that it would invalidate all existing solutions. There are already something like 26,748 students who have worked on this exercise.
Sorry, something went wrong.
| "<html>\n <body>\n <h1>Hello, World!</h1>\n </body>\n</html>\n" | ||
| ``` | ||
|
|
||
| For code that should work on varying operating systems Java offers [`System.lineSeparator()`][system-line-separator], which returns the system-dependent line separator string. |
There was a problem hiding this comment.
Wouldn't using the System.lineSeparator require string concatenation that comes later? I wonder if it would flow better if this section came after string concatenation. Other than that, I think it would be handy to have an example showing how to use this.
Sorry, something went wrong.
There was a problem hiding this comment.
I've moved that paragraph further down and added an example in e713aae
Sorry, something went wrong.
There was a problem hiding this comment.
But we could expand the log-levels task and add [no important files changed], no?
I also thought you could add optional tasks to a concept, which are not required to progress to the next concept. Can't find it in the docs rn though. Did I dream that up?
Edit: seems what I'm thinking of are practice exercises getting associated with a concept
Sorry, something went wrong.
- Add multi-line strings / text blocks (Java 15) - Add explanation of newlines / end of line chars, so students can understand the motivation behind text blocks
Co-authored-by: Kah Goh <villastar@yahoo.com.au>
Co-authored-by: Kah Goh <villastar@yahoo.com.au>
| ```java | ||
| String multilineHtml = "<html>\n <body>\n <h1>Hello, World!</h1>\n </body>\n</html>\n"; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Something still seems weird about the flow because we revisit line separators later. Perhaps we could add a sentence like Alternatively, we can use String.format or ``System.lineSeparator()` to add system independent line separator (discussed later).
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
pull request
Noticed that the String concept was lacking text blocks.
While there are quite some details and intricacies to text blocks, they're not relevant for the level of detail the syllabus is aiming for, therefore it doesn't make sense to have them as an extra concept imo.
I added infos about newlines so students can appreciate the motivation behind text blocks.
Looking forward to your feedback. :)
Reviewer Resources:
Track Policies