state-of-tic-tac-toe: add missing test cases for invalid board states by MathJAY10 · Pull Request #3153 · exercism/java · GitHub

Summary of Changes(For Issue #3150 )

This PR implements missing canonical test cases for state-of-tic-tac-toe from problem-specifications:

Added missing test cases in StateOfTicTacToeTest.java:
- 5a84757a-fc86-4328-aec9-a5759e6ed35d: Invalid board - O kept playing after X wins
- cf25543d-583a-4656-b9ab-f82dc00a4a02: Invalid board - X kept playing after O wins
Updated Reference Solution:
- Updated .meta/src/reference/java/StateOfTicTacToe.java to validate move counts after a victory condition is met.

Testing

Ran ./gradlew test locally — all 29 tests completed successfully with 0 failures.

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Please update the test cases to match the latest canonical-data.json rather than using assumed values, and remove the comments that were added since they aren't needed in the final solution. Also, don't forget to update test.toml using configlet (see #2959 for more information).

Please update the test values to match those in the canonical-data.json

Please refer to this: https://github.com/exercism/problem-specifications/blob/main/exercises/state-of-tic-tac-toe/canonical-data.json#L430

Suggested change

      
                    // --- NAYE CHECKS START ---
          
                    // Agar X jeeta hai, toh xCount zaroor (oCount + 1) hona chahiye. Agar barabar hai, matlab O ne extra move chala!

Suggested change

      
                    // Agar O jeeta hai, toh xCount zaroor oCount ke barabar hona chahiye. Agar xCount zyaada hai, matlab X ne extra move chala!

Suggested change

// --- NAYE CHECKS END ---

Hi @jagdish-15 , I have updated StateOfTicTacToeTest.java to align with canonical-data.json and cleaned up the comments in StateOfTicTacToe.java. All tests are passing locally. Could you please take another look?

Thanks for the updates! The test cases and reference solution look good now. The only remaining thing is to update test.toml using configlet. Please refer to the instructions in #2959: #2959 (comment). Once that's done, this should be good to go.

hey! @jagdish-15 please check the new changes! sync tests.toml using configlet

Looks like the CI Checkstyle check is unhappy

@jagdish-15 please check again!

@jagdish-15

Suggested change

      
            package exercises.practice.state_of_tic_tac_toe; // Apne project ke according package line rehne dena agar lagi ho

Could you please remove this

@jagdish-15 really sorry for bad code and comments, please check !

Please don't remove these from any of the tests, including the import statement.

…va/StateOfTicTacToe.java Co-authored-by: Jagdish Prajapati <jagadishdrp@gmail.com>

…icTacToeTest.java Co-authored-by: Jagdish Prajapati <jagadishdrp@gmail.com>

state-of-tic-tac-toe: add missing test cases for invalid board states

f4f2147

jagdish-15 requested changes Jul 31, 2026

View reviewed changes

fix: align test cases with canonical data and clean up comments

c5707fe

chore: sync tests.toml using configlet

2f40668

Merge branch 'main' into add-state-of-tic-tac-toe-tests

1b7622d

fix: enable all tests and add trailing newline

3d7ca76

fix: enable all tests and resolve checkstyle newline errors

3191e64

MathJAY10 commented Aug 2, 2026

View reviewed changes

jagdish-15 reviewed Aug 2, 2026

View reviewed changes

remove comments

0109b2f

MathJAY10 requested a review from jagdish-15 August 2, 2026 10:47

final commit for endlines

a89e428

jagdish-15 requested changes Aug 2, 2026

View reviewed changes

MathJAY10 and others added 4 commits August 2, 2026 18:16

Update exercises/practice/state-of-tic-tac-toe/.meta/src/reference/ja…

f61bd06

…va/StateOfTicTacToe.java Co-authored-by: Jagdish Prajapati <jagadishdrp@gmail.com>

Update exercises/practice/state-of-tic-tac-toe/.meta/src/reference/ja…

0bf1a32

…va/StateOfTicTacToe.java Co-authored-by: Jagdish Prajapati <jagadishdrp@gmail.com>

Update exercises/practice/state-of-tic-tac-toe/src/test/java/StateOfT…

400bfb8

…icTacToeTest.java Co-authored-by: Jagdish Prajapati <jagadishdrp@gmail.com>

rectify code

98756f0

MathJAY10 requested a review from jagdish-15 August 2, 2026 13:01

jagdish-15 approved these changes Aug 2, 2026

View reviewed changes

jagdish-15 merged commit d8a4083 into exercism:main Aug 2, 2026
8 checks passed

+                  public void testInvalidBoardOKeptPlayingAfterXWins() {
+                      assertThatExceptionOfType(IllegalArgumentException.class)
+                          .isThrownBy(() -> stateOfTicTacToe.determineState(new String[]{"XXX", "OO ", "O  "}))

+                  public void testInvalidBoardXKeptPlayingAfterOWins() {
+                      assertThatExceptionOfType(IllegalArgumentException.class)
+                          .isThrownBy(() -> stateOfTicTacToe.determineState(new String[]{"OOO", "XX ", "XX "}))

		// --- NAYE CHECKS START ---
		// Agar X jeeta hai, toh xCount zaroor (oCount + 1) hona chahiye. Agar barabar hai, matlab O ne extra move chala!

+                              "Impossible board: game should have ended after the game was won"
+                          );
+                      }
+                      // --- NAYE CHECKS END ---

		package exercises.practice.state_of_tic_tac_toe; // Apne project ke according package line rehne dena agar lagi ho

                       ).isEqualTo(GameState.WIN);
                   }
-                  @Disabled("Remove to run test")

state-of-tic-tac-toe: add missing test cases for invalid board states by MathJAY10 · Pull Request #3153 · exercism/java · GitHub

Uh oh!

Uh oh!

state-of-tic-tac-toe: add missing test cases for invalid board states - #3153

state-of-tic-tac-toe: add missing test cases for invalid board states#3153jagdish-15 merged 12 commits intoexercism:mainexercism/java:mainfrom MathJAY10:add-state-of-tic-tac-toe-testsMathJAY10/javaExercism:add-state-of-tic-tac-toe-testsCopy head branch name to clipboard

Conversation

MathJAY10 commented Jul 31, 2026

Summary of Changes(For Issue #3150 )

Testing

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

jagdish-15 left a comment

Choose a reason for hiding this comment

Uh oh!

jagdish-15 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

jagdish-15 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

jagdish-15 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

jagdish-15 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

jagdish-15 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

MathJAY10 commented Jul 31, 2026

Uh oh!

jagdish-15 commented Jul 31, 2026

Uh oh!

MathJAY10 commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jagdish-15 commented Aug 2, 2026

Uh oh!

MathJAY10 commented Aug 2, 2026

Uh oh!

MathJAY10 left a comment

Choose a reason for hiding this comment

Uh oh!

jagdish-15 Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

MathJAY10 commented Aug 2, 2026

Uh oh!

jagdish-15 Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

state-of-tic-tac-toe: add missing test cases for invalid board states#3153
jagdish-15 merged 12 commits into
exercism:mainfrom
MathJAY10:add-state-of-tic-tac-toe-tests

MathJAY10 commented Aug 1, 2026 •
edited
Loading