Incomplete draft for discussion. This is a fairly direct port from C#.
Is this suitable for the datetime concept? Usual options:
Use with minor tweaks.
Use after substantial revision.
Scrap it and think of something better.
Some things I'm unhappy about:
It's all datetime.datetime, nothing much about time or date
Task 2 is locale-specific. It works for me (in the US) and should be OK on the test runner, but will fail for non-English locales. The test file could set the locale to EN-US, but I'm reluctant to mess with users' machine settings unless I'm very confident of restoring it at the end of the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete draft for discussion. This is a fairly direct port from C#.
Is this suitable for the datetime concept? Usual options:
Some things I'm unhappy about: