robot-name approach: fix typos, minor rephasing/improvements by petrem · Pull Request #4051 · exercism/python · GitHub

Fixed a few typos.
Rephrased here and there where I subjectively thought it useful. Please let me know if they're undesirable.
Expanded some contractions - this might help non-native speakers.
When another approach is mentioned, added link to it - hopefully this is useful rather than an distraction
I thought the explanation about the alternative to using the walrus operator was not clear, so rephrased and added a code snippet. I hope this is useful.

Additionally, the phrase

We call `reset` from `__init__` - it is syntactically valid to do it the other way around, but it is not considered good practice to call [dunder methods][dunder-methods] directly.

seems misleading to me: calling __init__ from other methods seems to me significantly worse than calling other dunder methods, as it may lead to future bugs.
Arguably, for tooling support, we should assign to self.name in __init__() explicitly:

def __init__(self):
    self.name = self._get_new_name()
def reset(self):
    self.name = self._get_new_name()
def _get_new_name(self):
     ...  # what reset() did

but this looks ugly and confusing.

- Fixed a few typos. - Rephrased here and there where I subjectively thought it useful. Please let me know if they're undesirable. - Expanded some contractions - this might help non-native speakers. - When another approach is mentioned, added link to it - hopefully this is useful rather than an distraction - I thought the explanation about the alternative to using the walrus operator was not clear, so rephrased and added a code snippet. I hope this is useful.

A few nits (some contractions you missed), and a few rewordings that came to mind as I reviewed. Overall, though -- this is great! This is certainly within what I had in mind, and I wouldn't mind if you had more to add or more edits (at least for the approaches I wrote 😄 ). Let me know if you prefer comments or "request changes". I typically do comments or approval and leave you to take my suggestions ... or not.

Great start... a couple of nits for style.

Style suggestion:

Blank line after headings (currently missing).

Tend to trailing white space, there are two occurrences where this happens... I will mention in review here.

Would it be OK if I also added blank lines before/after the code snippets in the markdowns? It should not make a difference when rendered, but I find it easier to read and edit the markdown that way -- is that something that works for everybody or just my personal quirk?

Would it be OK if I also added blank lines before/after the code snippets in the markdowns?

Please do. Not just your quirk: mine as well. Didn't do it on my first pass, because I didn't want to bog things down. But absolutely!

Suggested change

      
                def __init__(self): 
          
                    self.reset()
          
                def __init__(self):
          
                    self.reset()

There is at least one other trailing white space lurking that is similar to the above...

Thanks, I dealt with trailing whitespace and lines after headings in one commit.

…/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

…ent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

…/content.md Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>

Thanks everyone for comments and suggestions!

A few nits (some contractions you missed), and a few rewordings that came to mind as I reviewed.

Thanks!

There still are a few contractions. I find some of the more common ones, like "isn't" or "won't", to be useful. They "roll down well", and make the tone a bit of a less formal.

But please let me know if the agreed style/wisdom is to not use contractions at all, or seldom, or ...

While looking at the text again, I found this one that might not be grammatically correct, but as I didn't study grammar I'm not sure:

ensure that it's not been previously used

I think this should read, perhaps, "ensure that it hasn't been ...".

Overall, though -- this is great! This is certainly within what I had in mind, and I wouldn't mind if you had more to add or more edits (at least for the approaches I wrote 😄 ).

Thanks :-)

Let me know if you prefer comments or "request changes". I typically do comments or approval and leave you to take my suggestions ... or not.

This may sound strange, but I don't think I actually know the difference. I'm not too familiar with github core reviews. I worked a lot with bitbucket and just very occasionally with github and gitlab. In general, please do as you think it is more appropriate or whatever is more convenient.

ensure that it's not been previously used
“it’s” can be short for “it is” or “it has” since both end in s. The reader would need additional context to pick “it has” which is provided by “been” so the action occurred at an unspecified time in the past. Contracting “has not” instead of “it has” would make that a bit clearer up front.

“it’s” can be short for “it is” or “it has” since both end in s.

oh, 'tis right, only I'd stopped for a second and thunk..

@petrem - than you so much for taking this on! Give a head's up when you are "done done", and I can give things a quick once-over and then merge. 😄

@BethanyG thank you for reviewing, I'm done (unless new evidence to the contrary is surfaced).

On 25/12/21 03:26AM, PetreM wrote: @petrem commented on this pull request. > @@ -1,5 +1,5 @@ Would it be OK if I also added blank lines before/after the code snippets in the markdowns? It should not make a difference when rendered, but I find it easier to read and edit the markdown that way -- is that something that works for everybody or just my personal quirk?

Not only OK, it would be preferred.

On 25/12/21 03:50AM, PetreM wrote: @petrem commented on this pull request. > def __init__(self): self.reset() Thanks, I dealt with trailing whitespace and lines after headings in one commit.

Thanks!

Pushing the big, green button! Thanks again, @petrem! 🚀

…sm#4051) * robot-name approach: fix typos, minor rephasing/improvements - Fixed a few typos. - Rephrased here and there where I subjectively thought it useful. Please let me know if they're undesirable. - Expanded some contractions - this might help non-native speakers. - When another approach is mentioned, added link to it - hopefully this is useful rather than an distraction - I thought the explanation about the alternative to using the walrus operator was not clear, so rephrased and added a code snippet. I hope this is useful. * Update exercises/practice/robot-name/.approaches/mass-name-generation/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/robot-name/.approaches/mass-name-generation/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/robot-name/.approaches/mass-name-generation/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/robot-name/.approaches/mass-name-generation/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/robot-name/.approaches/name-on-the-fly/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/robot-name/.approaches/name-on-the-fly/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/robot-name/.approaches/mass-name-generation/content.md Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com> * blank lines after headers and remove trailing whitespace * add blank lines around code snippets and expand one more contraction --------- Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>

BethanyG reviewed Dec 20, 2025

View reviewed changes

BNAndras reviewed Dec 20, 2025

View reviewed changes

Comment thread exercises/practice/robot-name/.approaches/mass-name-generation/content.md Outdated

kotp reviewed Dec 21, 2025

View reviewed changes

petrem and others added 8 commits December 21, 2025 13:12

Update exercises/practice/robot-name/.approaches/mass-name-generation…

56c302b

…/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

Update exercises/practice/robot-name/.approaches/mass-name-generation…

d9def28

…/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

Update exercises/practice/robot-name/.approaches/mass-name-generation…

229c957

…/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

Update exercises/practice/robot-name/.approaches/mass-name-generation…

eddb5fe

…/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

Update exercises/practice/robot-name/.approaches/name-on-the-fly/cont…

18b8d00

…ent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

Update exercises/practice/robot-name/.approaches/name-on-the-fly/cont…

4c4f1e0

…ent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

Update exercises/practice/robot-name/.approaches/mass-name-generation…

36858d7

…/content.md Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>

blank lines after headers and remove trailing whitespace

4eea484

add blank lines around code snippets and expand one more contraction

78e5ac2

BethanyG approved these changes Dec 21, 2025

View reviewed changes

BethanyG merged commit d069b5d into exercism:main Dec 21, 2025
8 checks passed

BethanyG mentioned this pull request Dec 24, 2025

[Exercise Approaches]: Audit/Cleanup of Track Approaches 2025/2026 #4055

Closed

BethanyG mentioned this pull request May 21, 2026

[Exercise Approaches]: Audit/Cleanup of Track Approaches 2026 (part 2) #4197

Closed

		@@ -1,5 +1,5 @@
		# Mass Name Generation
		We'd first have to generate all the possible names, shuffle them, and then use `next` (the simplest way) or maintain a `current_index` and get the name.

robot-name approach: fix typos, minor rephasing/improvements by petrem · Pull Request #4051 · exercism/python · GitHub

Repository navigation

robot-name approach: fix typos, minor rephasing/improvements - #4051

robot-name approach: fix typos, minor rephasing/improvements#4051BethanyG merged 10 commits intoexercism:mainexercism/python:mainfrom petrem:approaches_robot-name_typos_and_minor_rephrasingpetrem/exercism--python:approaches_robot-name_typos_and_minor_rephrasingCopy head branch name to clipboard

Conversation

petrem commented Dec 20, 2025

Uh oh!

BethanyG left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kotp left a comment

Choose a reason for hiding this comment

Uh oh!

kotp Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

petrem Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

BethanyG Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

kotp Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

petrem Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

petrem commented Dec 21, 2025

Uh oh!

BNAndras commented Dec 21, 2025

Uh oh!

petrem commented Dec 21, 2025

Uh oh!

BethanyG commented Dec 21, 2025

Uh oh!

petrem commented Dec 21, 2025

Uh oh!

kotp commented Dec 21, 2025 via email

Uh oh!

kotp commented Dec 21, 2025 via email

Uh oh!

BethanyG commented Dec 21, 2025

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

robot-name approach: fix typos, minor rephasing/improvements#4051
BethanyG merged 10 commits into
exercism:mainfrom
petrem:approaches_robot-name_typos_and_minor_rephrasing