FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add skeleton files for exercises by pheanex · Pull Request #415 · exercism/python · GitHub

  1. exercism
  2. python

Repository navigation

Add skeleton files for exercises - #415

Merged
behrtam merged 1 commit into
exercism:masterfrom
pheanex:add-skeleton-files
Mar 12, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Add skeleton files for exercises#415
behrtam merged 1 commit into
exercism:masterfrom
pheanex:add-skeleton-files

Conversation

pheanex commented Feb 16, 2017

Copy link
Copy Markdown
Contributor

No description provided.

pheanex mentioned this pull request Feb 16, 2017
Closed
behrtam reviewed Mar 8, 2017
View reviewed changes
Comment thread exercises/linked-list/linked_list.py Outdated


class LinkedList(object):
class LinkedList:

behrtam Mar 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As we support Python 2 & 3 we should subclass from object to have new style classes in both versions. That goes for all other cases as well. Apart from that this is good to go.

pheanex Mar 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

behrtam commented Mar 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

You could also use one of the available keywords (https://help.github.com/articles/closing-issues-via-commit-messages/) in your commit message to auto close issue #272 when this gets merged.

pheanex force-pushed the add-skeleton-files branch 2 times, most recently from 1fc217c to 3e87228 Compare March 12, 2017 13:19

pheanex commented Mar 12, 2017

Copy link
Copy Markdown
Contributor Author

Ah thank you for the keyword tip. I forgot about that one :-)

pheanex force-pushed the add-skeleton-files branch from 3e87228 to d38bbc9 Compare March 12, 2017 13:21
behrtam merged commit de66a31 into exercism:master Mar 12, 2017
kytrinyx mentioned this pull request May 28, 2017
Closed
behrtam mentioned this pull request Jun 4, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
behrtam behrtam left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL