FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[RNA Transcription & Atbash Cipher]: Approaches Cleanup by Yrahcaz7 · Pull Request #4191 · exercism/python · GitHub

Repository navigation

[RNA Transcription & Atbash Cipher]: Approaches Cleanup - #4191

Merged
BethanyG merged 4 commits into
exercism:mainfrom
Yrahcaz7:rna-atbash-approach-cleanup
May 19, 2026
Merged

BethanyG merged 4 commits into
exercism:mainfrom
Yrahcaz7:rna-atbash-approach-cleanup

Conversation

Copy link
Copy Markdown
Contributor

As discussed in this issue.

BethanyG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am being a pendant here, but I think it is really important to poke students about "character" vs "code point". We have to be careful, even with basic ASCII to not confuse the two - it becomes a deadly mental model the minute you get to anything with a diacritical mark or accent. Its even worse when you work with any multi-codepoint glyphs (like emoji or Kanji). It's a ...whole thing.

Otherwise, great work here. Thanks so much for cleaning this mess up.

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>

BethanyG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Still a tad triggered by those last "character" refs but agree they are better as-is for clarity. (Or at least I hope that brings clarity).

Copy link
Copy Markdown
Member

Shall we let this one sit and re-read, or are you read for merge? 😄

Copy link
Copy Markdown
Contributor Author

You bet I am ready to merge! I am not letting that slop err... subpar approach remain there any longer!

BethanyG merged commit 79149c3 into exercism:main May 19, 2026
7 checks passed

Copy link
Copy Markdown
Member

BTW, if another approach for any of these comes to you, please feel free to write one (or not!).

Yrahcaz7 deleted the rna-atbash-approach-cleanup branch May 19, 2026 22:41
BethanyG changed the title RNA Transcription and Atbash Cipher approach cleanup [RNA Transcription & Atbash Cipher]: Approaches Cleanup Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL