[Collatz Conjecture Dig Deeper]: Corrections & Edit - #4250
BethanyG merged 4 commits into
Conversation
Sorry, something went wrong.
|
|
||
| The key to this exercise is to check if the number is even or odd and then perform the correct operation. | ||
| Under this process you are supposed to count how many steps it takes to get to one. | ||
| Under this process (_if the data is not [pathological][collatz-pathological]_), the result will settle at 1. |
There was a problem hiding this comment.
This link does seem useful, but it being right here confused me, as it does not mention the word "pathological".
Sorry, something went wrong.
There was a problem hiding this comment.
I think we keep it. Unless you'd like to replace it with a def of "pathological data"? The point being ... and I was frustrated I couldn't find a clearer article, but if you use something like 27 (which takes 111 steps to settle), or some other numbers, it can take a long time to come to 1. That being said, we know all numbers up to about 2^71 will settle, it is just a matter of the number of steps.
Sorry, something went wrong.
There was a problem hiding this comment.
Open to suggestions on how to describe the link.
Sorry, something went wrong.
There was a problem hiding this comment.
went with
(if the input number doesn't create an excessively [long cycle][collatz-pathological]), the result will settle at 1.
Sorry, something went wrong.
| "introduction": { | ||
| "authors": ["bethanyg", "meatball133"], | ||
| "contributors": [] | ||
| "contributors": ["Yrahcaz7"] |
There was a problem hiding this comment.
I thought the usernames had to be in lowercase... Does the casing actually not matter?
Sorry, something went wrong.
There was a problem hiding this comment.
Not sure. I've had cases where I swear my name in lowercase didn't count ... but IDK for sure. Maybe keep an eye out and see? We can come back later and change things.
Sorry, something went wrong.
|
I think the approach docs look a lot better now. recursion might still be a little awkward, but it's not that bad. |
Sorry, something went wrong.
Suggestions from review. Co-authored-by: Yrahcaz <74512479+Yrahcaz7@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
… in recursion note.
See issue #4197 for details.
I tried my best to address the awkwardness, but failed in some cases. Recursion might need a re-write.