FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Acronym] Approach docs cleanup by Yrahcaz7 · Pull Request #4258 · exercism/python · GitHub

  1. exercism
  2. python

Repository navigation

[Acronym] Approach docs cleanup - #4258

Merged
BethanyG merged 6 commits into
exercism:mainfrom
Yrahcaz7:acronym-approach-cleanup
Jun 27, 2026
ConversationCommits (6)ChecksFiles changed
Merged

[Acronym] Approach docs cleanup#4258
BethanyG merged 6 commits into
exercism:mainfrom
Yrahcaz7:acronym-approach-cleanup

Conversation

Yrahcaz7 commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

As discussed in issue #4197.

Yrahcaz7 changed the title Acronym approach cleanup [Acronym] Approach docs cleanup Jun 27, 2026

Yrahcaz7 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

For some reason the CI failed... I don't think I modified anything outside the .approaches folder though?

Yrahcaz7 marked this pull request as ready for review June 27, 2026 03:04

Yrahcaz7 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

@BethanyG, do you know what's going on with the CI?

Yrahcaz7 mentioned this pull request Jun 27, 2026
Closed

BethanyG commented Jun 27, 2026

Copy link
Copy Markdown
Member

@Yrahcaz7 -- Yuppers. If you take a look at the housekeeping run, you'll see that when the tests were regenerated for the track, the Bob exercise failed because there were new tests added upstream. I'll regenerate the tests and merge them, and then we can pull the changes into your branch so that the CI will pass.

BethanyG commented Jun 27, 2026

Copy link
Copy Markdown
Member

Huh. Usually I can do this from the interface, but I don't see the button. I've merged the changes - can you pull them into your branch? That should fix the CI.

Yrahcaz7 added 5 commits June 27, 2026 03:04
formatting fixes & replace "scrub" with "clean"
9af50e9 
also fix missing links in `introduction.md`
update performance snippet to match article
83b4f0e 
also correct a few statements about performance
fix the intro present in most approaches
b50b857 
also fix a few incorrect things in the regex approaches
improve clarity and fix rendering issues
afbd8ad
Separate re.finditer() into a variation
935f65d 
also add username to contributors array
Yrahcaz7 force-pushed the acronym-approach-cleanup branch from cb3683d to 935f65d Compare June 27, 2026 07:05
Yrahcaz7 requested a review from BethanyG June 27, 2026 16:55
BethanyG approved these changes Jun 27, 2026
View reviewed changes

BethanyG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just one nit - and I won't be fussed if it is ignored. 😄 Thanks again for doing this!

Comment thread exercises/practice/acronym/.approaches/regex-sub/content.md Outdated
Update exercises/practice/acronym/.approaches/regex-sub/content.md
3b4bfc3 
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
BethanyG merged commit 2bfdfee into exercism:main Jun 27, 2026
7 checks passed

BethanyG commented Jun 27, 2026

Copy link
Copy Markdown
Member

WOOT!! 😄

Yrahcaz7 deleted the acronym-approach-cleanup branch June 27, 2026 21:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BethanyG BethanyG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL