[Roman Numerals] Approach docs improvements - #4300
Merged
BethanyG merged 3 commits intoSep 30, 2026
Merged
BethanyG merged 3 commits into
BethanyG merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@Yrahcaz7 - Thank you so much for this!
Happy to have you add those two things here, if you'd like. We may as well change whatever needs changing, since we are not likely to not this way again soon. 🙂 |
Sorry, something went wrong.
Yrahcaz7
marked this pull request as ready for review
September 30, 2026 18:05
BethanyG
approved these changes
Sep 30, 2026
BethanyG
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! 🚀
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers all of the remaining audit items listed in #4289 (see issue 4197 for the original discussion). It also adds a few links to the Python docs where relevant.
However, this PR is still a draft because the recursion approach needs more explanation, and the itertools.starmap() approach would likely benefit from reorganization (these two items were not in the original audit list).