fixed issue with left bracket in path to test file (#17357) · explain116/vscode-python@a68f98f · GitHub

explain116 / vscode-python Public

forked from microsoft/vscode-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a68f98f

Browse filesBrowse the repository at this point in the historyBrowse files

authored

fixed issue with left bracket in path to test file (microsoft#17357)

* fixed microsoft#17461 issue with left bracket in path to test file * added news for 17461 issue * Update news/2 Fixes/17461.md Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Alexey Bogdanov <ilexei@yandex-team.ru> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>

1 parent 7847a25 commit a68f98f
Copy full SHA for a68f98f

2 files changed

+29-1Lines changed: 29 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• news/2 Fixes
  • 17461.md
• pythonFiles/testing_tools/adapter/pytest
  • _pytest_item.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎news/2 Fixes/17461.md‎

Copy file name to clipboard

+2Lines changed: 2 additions & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,2 @@
	1	+ Changed the way of searching left bracket [ in case of subsets of tests.
	2	+ (thanks [ilexei](https://github.com/ilexei))

Collapse file

‎pythonFiles/testing_tools/adapter/pytest/_pytest_item.py‎

Copy file name to clipboardExpand all lines: pythonFiles/testing_tools/adapter/pytest/_pytest_item.py

+27-1Lines changed: 27 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -434,6 +434,32 @@ def _parse_node_id(
434	434	)
435	435
436	436
	437	+ def _find_left_bracket(nodeid):
	438	+ """Return tuple of part before final bracket open, separator [, and the remainder.
	439	+ Notes:
	440	+ Testcase names in case of parametrized tests are wrapped in [<test-case-name>].
	441	+ Examples:
	442	+ dirname[sometext]/dirname/testfile.py::testset::testname[testcase]
	443	+ => ('dirname[sometext]/dirname/testfile.py::testset::testname', '[', 'testcase]')
	444	+ dirname/dirname/testfile.py::testset::testname[testcase]
	445	+ => ('dirname/dirname/testfile.py::testset::testname', '[', 'testcase]')
	446	+ dirname/dirname/testfile.py::testset::testname[testcase[x]]
	447	+ => ('dirname/dirname/testfile.py::testset::testname', '[', 'testcase[x]]')
	448	+ """
	449	+ if not nodeid.endswith("]"):
	450	+ return nodeid, "", ""
	451	+ bracketcount = 0
	452	+ for index, char in enumerate(nodeid[::-1]):
	453	+ if char == "]":
	454	+ bracketcount += 1
	455	+ elif char == "[":
	456	+ bracketcount -= 1
	457	+ if bracketcount == 0:
	458	+ n = len(nodeid) - 1 - index
	459	+ return nodeid[:n], nodeid[n], nodeid[n + 1 :]
	460	+ return nodeid, "", ""
	461	+
	462	+
437	463	def _iter_nodes(
438	464	testid,
439	465	kind,
@@ -448,7 +474,7 @@ def _iter_nodes(
448	474	testid = "." + _pathsep + testid
449	475
450	476	if kind == "function" and nodeid.endswith("]"):
451		- funcid, sep, parameterized = nodeid.partition("[")
	477	+ funcid, sep, parameterized = _find_left_bracket(nodeid)
452	478	if not sep:
453	479	raise should_never_reach_here(
454	480	nodeid,

0 commit comments

Comments

0 (0)