fixed issue with left bracket in path to test file - #17357
fixed issue with left bracket in path to test file#17357Paula (paulacamargo25) merged 3 commits into
Conversation
Sorry, something went wrong.
|
|
Sorry, something went wrong.
Karthik Nadig (karthiknadig)
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please create a bug for this issue, and provide a new item.
Sorry, something went wrong.
|
For the linting issue, please make sure you use black formatter to format your changes. |
Sorry, something went wrong.
|
Hi Karthik, Thank you for your review and feedback! I accepted your changes and added additional check in case function is used outside the proper if. I also created an issue #17461 and added it to commit message, but it's unclear to me if they have link now (currently, I don't see a link between them). |
Sorry, something went wrong.
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
|
Hi Karthik, I can't merge this PR - Only those with write access to this repository can merge pull requests. So it's up to you :) |
Sorry, something went wrong.
|
ilexei I am waiting for Paula (@paulacamargo25) to take a look and merge. You don't have to do anything else for now :) |
Sorry, something went wrong.
Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft#17357, fixing microsoft#17676.
Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft#17357, fixing microsoft#17676.
Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft#17357, fixing microsoft#17676.
* Use pytest data to extract the parametrised decoration Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for #17357, fixing #17676. * Add news entry * Update news/2 Fixes/17676.md Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
…ode-python#17881) * Use pytest data to extract the parametrised decoration Rather than try and parse out the parametrized portion of the nodeid (delimited by square brackets but possibly containing square brackets), use native [pytest item attributes](https://docs.pytest.org/en/6.2.x/reference.html#function) to separate out the decoration. Better solution for microsoft/vscode-python#17357, fixing microsoft/vscode-python#17676. * Add news entry * Update news/2 Fixes/17676.md Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Hi!
I bumped into issue when pytest crashes on scanning my folders.
I had a structure like this
.
|-folder1-test_public.py
|-folder2-test_public.py
|-folder2[2]-test_public.py
And in case of folder folder2[2] the name of the test was determined wrong.
I searched the similar issue but found nothing.
Hope this little fix help not only me.