FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: allow field access on concrete types behind interface values by snaffi · Pull Request #952 · expr-lang/expr · GitHub

/ expr Public

feat: allow field access on concrete types behind interface values - #952

Merged
antonmedv merged 6 commits into
expr-lang:masterfrom
snaffi:feature/get-embedded-interface-properties
Jun 4, 2026
Merged

feat: allow field access on concrete types behind interface values#952
antonmedv merged 6 commits into
expr-lang:masterfrom
snaffi:feature/get-embedded-interface-properties

Conversation

snaffi commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Issue
#951

Comment thread vm/runtime/runtime.go Outdated
fk := f.Type.Kind()

// Dereference pointers to get to the underlying type.
for fk == reflect.Ptr {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lets use our deref package.

Comment thread vm/runtime/runtime.go
snaffi added 2 commits May 19, 2026 09:19
…dedInterfaces

Replace hand-rolled pointer/interface unwrap loops with deref.Value and
deref.Type, consistent with how Fetch already dereferences values.

Add white-box unit tests covering each branch (100% coverage of the
function): plain struct, embedded interface with/without field, pointer
to struct concrete value, nil concrete value, nil embedded pointer,
nested embedded struct, nested embedded interface, non-struct concrete
value, expr:"-" tag, and empty concrete struct.

snaffi commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@antonmedv hello, I appologize for late response. Yours comments have been addressed.

Copy link
Copy Markdown
Member

Looks like something with tests.

snaffi commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@antonmedv hello

Looks like GA jobs are stuck, could you please assist a little bit?

antonmedv merged commit 2010a11 into expr-lang:master Jun 4, 2026
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL