handle arbitrary slice types in sort builtin - #968
Open
netliomax25-code wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
antonmedv
approved these changes
May 29, 2026
Copy link
Copy Markdown
Member
|
looks like a lot of generated expressions now are falling |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Yeah, the error path was too broad. sort used to silently return empty for anything that wasn't one of the special-cased slice types, so the generated corpus has a bunch of expressions sorting maps/nil/struct slices that relied on that. Dropped the error and narrowed the reflection fallback to only pick up slices/arrays whose element kind is actually orderable (ints, uints, floats, string, bool). Everything else keeps the old no-op behavior. gen tests are green again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
any update? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort only special-cases []any/[]int/[]float64/[]string, so a dynamically typed slice like []int64 or []uint falls through the switch and returns an empty slice with no error, silently dropping every element. Handle any slice or array through reflection like reverse and uniq do.