fix(checkExact): returns unknown nested fields under a wildcard - #1281
fix(checkExact): returns unknown nested fields under a wildcard#1281fedeci wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
coverage: 100.0%. remained the same |
Sorry, something went wrong.
gustavohenke
left a comment
There was a problem hiding this comment.
Smart way of fixing this, but I'd like to discuss a gotcha with this.
A custom validator can validate any aspect of an object/array, which is an undocumented assumption that this PR breaks. It's arguable whether one could still want this behaviour when there's isArray(), isObject(), among others, nowadays.
Should we keep this behaviour?
If yes, we need to mark fields with any user-specified custom validators (which excludes e.g. isArray()/isObject(), implemented using custom()) as being considered known "as a whole", whereas others are "partially" known.
Either way, we need to document it.
Sorry, something went wrong.
Description
Fixes #1242
To-do list