refactor(json): simplify strict mode error string construction - #692
Merged
UlisesGascon merged 2 commits intoJan 6, 2026
Merged
UlisesGascon merged 2 commits into
UlisesGascon merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
UlisesGascon
approved these changes
Jan 5, 2026
efekrskl
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor the way we create strict mode error strings
the concat in a loop is the least efficient way across memory and operations to do this, so refactor to approach that uses fewer allocations and operations
Different approach from #693 bc of node version requirements not allowing us to use string.repeat()