Refactor toBuffer function to simplify buffer check logic - #201
Merged
bjohansebas merged 1 commit intoNov 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The function now directly returns the existing buffer if the input is already a buffer, eliminating the need for a negated condition. This improves code readability and maintains functionality by ensuring that non-buffer inputs are converted to a buffer using the specified encoding.
UlisesGascon
approved these changes
Oct 30, 2024
bjohansebas
approved these changes
Oct 31, 2024
bjohansebas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can it still be included in this patch version? |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function now directly returns the existing buffer if the input is already a buffer, eliminating the need for a negated condition. This improves code readability and maintains functionality by ensuring that non-buffer inputs are converted to a buffer using the specified encoding.