How to handle error when python's path is invalid? · Issue #118 · extrabacon/python-shell · GitHub

            const PythonShell = require('python-shell');
            const options = {
                pythonPath: './notthepythonpath',
                scriptPath: 'scriptdir',
                args: [0, 0, 400, 400, 1, store.get('outputPath')],
                mode: 'text',
            };
            let pyshell = new PythonShell('script.py', options);
            pyshell.on('error', (err) => {
                alert(err);
            });

I've tried the callback ,and tried on('error') but both doesn't seem to catch it.

I'll have to look into that - the error event should fire for that.

Here's the code I use in arepl-vscode:

pyshell.childProcess.on('error', err => {
  let error:any = err; //typescript complains about type for some reason so defining to any
  this.pythonPreviewContentProvider.handleSpawnError(error.path, error.spawnargs[0], error.stack);
})

I ran into the same problem. I believe the root cause is with this line in python-shell:

this.childProcess = child_process_1.spawn(pythonPath, this.command, options);

the spawn() function can throw an exception if the path is invalid (see here nwjs/nw.js#1623). It appears that spawn must have an error handler attached like this:

spawn.on('error', function (err) {
    console.log('spawn error:', err);
});

This code is in PythonShell's constructor.

Could it be OS dependent behavior? I'm on Mac.

@sejsingffdc nah, I have windows and it does same thing.

I'll change the error event to also fire when the path is invalid.

Once I finish promise support (#77) the python process will be launched via a start method which will return or reject a promise based on whether it sucessfully launched the process.

fix #118

How to handle error when python's path is invalid? · Issue #118 · extrabacon/python-shell · GitHub

Repository navigation

How to handle error when python's path is invalid? #118

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

How to handle error when python's path is invalid? · Issue #118 · extrabacon/python-shell · GitHub

Repository navigation

How to handle error when python's path is invalid? #118

Description

Activity

Almenon commented on Apr 12, 2018

sejsingffdc commented on Oct 26, 2018

sejsingffdc commented on Oct 26, 2018

sejsingffdc commented on Nov 6, 2018

Almenon commented on Nov 22, 2018

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions